Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Tidies up the React mock logic + ReactDOM mocks + few tweaks #1835

Closed
wants to merge 3 commits into from
Closed

Tidies up the React mock logic + ReactDOM mocks + few tweaks #1835

wants to merge 3 commits into from

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented May 2, 2018 •
edited
Loading

Release notes: adds ReactDOM mocks to fb-www compatibility mode

This PR aims to do a bunch of things:

  • Tidy up the spaghetti React mock logic by adding in some helper functions
  • Add ReactDOM mocks, pathing the way for greater optimizations for first render
  • Swap the Get to a getProperty in isReactElement function
  • Make the fb-www mocks not ignored by eslint and fix the eslint issues after doing so

@trueadm trueadm requested a review from gaearon May 2, 2018 12:43
facebook-github-bot
facebook-github-bot reviewed May 2, 2018
View reviewed changes
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueadm @gaearon @facebook-github-bot