This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Rest syntax #1987
Closed
Rest syntax #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flow keeps crashing with |
|
It looks like the latest build has a real Flow issue. |
ManasJayanth
force-pushed
the
rest-syntax
branch
3 times, most recently
from
25a0358
to
631bda4
Compare
|
@hermanventer Can I please get some help with test262 tests? I'm not able to figure out which tests are failing because of this PR. I did spot some destructuring related failures earlier. Fixed them. |
|
Please rebase this when PR #2092 has been merged. |
|
@prometheansacrifice Please can you merge/rebase master on this PR? |
ManasJayanth
force-pushed
the
rest-syntax
branch
from
35fc1c8
to
65abc86
Compare
|
@trueadm All tests pass :) |
trueadm
approved these changes
Jun 12, 2018
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
caiismyname
pushed a commit
that referenced
this pull request
Jun 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: Adds support for rest syntax. Abstract Interpreter support pending.
Addresses #927