This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Ensure react lazy initializer is in the top generator body #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTillmann
reviewed
May 25, 2018
src/serializer/Emitter.js
Outdated
| while (topBody.parentBody !== undefined) { | ||
| topBody = topBody.parentBody; | ||
| } | ||
| // temproarily set the body to be the top parent body |
NTillmann
suggested changes
May 25, 2018
src/serializer/Emitter.js
Outdated
| @@ -504,4 +504,17 @@ export class Emitter { | |||
| invariant(!this._finalized); | |||
| return new BodyReference(this._body, this._body.entries.length); | |||
| } | |||
| emitLazyReactElementInitializer(statement: BabelNodeStatement): void { | |||
There was a problem hiding this comment.
I'd prefer it if we don't add such special cases to the Emitter. The Emitter is already confusing enough...
| @@ -96,7 +96,7 @@ export class ResidualReactElementSerializer { | |||
| t.callExpression(funcId, originalCreateElementIdentifier ? [originalCreateElementIdentifier] : []) | |||
| ) | |||
| ); | |||
| this.residualHeapSerializer.emitter.emit(statement); | |||
| this.residualHeapSerializer.emitter.emitLazyReactElementInitializer(statement); | |||
There was a problem hiding this comment.
If this intends to do what I think it does, then you want to do the following:
- Pass the result of
this.residualHeapSerializer.isReferencedOnlyByAdditionalFunction(value)(currently evaluated by caller) into this function; let's call itadditionalFunction. It should be defined by construction. - Then replace this line with the following:
this.residualHeapSerializer._getPrelude(additionalFunction).push(statement);There was a problem hiding this comment.
That's exactly what I want to do!
|
@NTillmann are you happy with the requested changes? |
NTillmann
approved these changes
May 25, 2018
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: none
We need to ensure we emit the ReactElement lazy initializer is in the top generator body (the function body) of the React component render. If we emit it in a nested generator body, it may not get called in the right place after we've nested many components. This also renames a bunch of functions to optimized functions rather than additional functions.
I've got an issue tracking the progress on a follow up PR to add regression tests for this PR: #2027