This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Refactor of createElement props/config to fix bugs + use snapshotting #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jun 1, 2018
src/evaluators/JSXElement.js
Outdated
| // i.e. <div {...something} /> --> React.createElement("div", something) | ||
| // if (abstractSpreadCount === 1 && astAttributes.length === 1) { | ||
| // return spreadValue; | ||
| // } |
There was a problem hiding this comment.
Yep, I was testing to make sure it worked with and without, but then forgot to enable it again :P
gaearon
reviewed
Jun 1, 2018
src/evaluators/JSXElement.js
Outdated
| flagPropsWithNoPartialKeyOrRef(realm, config); | ||
| } | ||
| } | ||
| applyObjectAssignConfigsFoReactElement(realm, config, abstractPropsArgs); |
NTillmann
reviewed
Jun 1, 2018
src/react/elements.js
Outdated
| } | ||
| } | ||
| } | ||
| // if defaultPropsEvauated === the amount of properties defaultProps has, then we've successfully |
There was a problem hiding this comment.
spelling of defaultPropsEvauated
NTillmann
approved these changes
Jun 1, 2018
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: fixes a range of spread bugs with ReactElements
This is a very important PR for React reconciliation, it fixes many undiscovered bugs and adds a huge amount of test coverage that was previously missing.
Whilst testing quite complex cases of JSX spreads in combination with defaultProps on our internal bundle I noticed that there were some bugs appearing, but because the branches where these bugs were appearing were not used on firstRender, it meant we got away with it on our internal tests.
We now use snapshotting and properly evaluateForEffects when recovering from
Object.assignwith ReactElement creation of config/props. We also properly use thetemporalAliasto ensure we reference the correct object.