This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Store consequentEffects and alternateEffects in consequent and alternate #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanventer
approved these changes
Jun 19, 2018
There was a problem hiding this comment.
@cblappert is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 26, 2018
Summary: Release note: Fix test runner and don't swallow invariant failures The recent changes to make the serializer test runner deal with promises, caused it to list every test that follows a failing test as also failing. I've also noticed that invariant failures can get swallowed. And as a result of that some test cases that should have failed with false invariants showed up as passing. Those failures were recently introduced by PR #2134. It boils down to a single line fix, which is also included with this. Closes #2155 Differential Revision: D8629298 Pulled By: hermanventer fbshipit-source-id: 467f7efdf119ea9d29083d4e41054e583b38a1ff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes: None
Follow up on #2110, this PR makes progress towards unifying PossiblyNormalCompletion and ForkedAbruptCompletion as well as unifying completion and effects.
Introduces
updateConsequentKeepingCurrentEffectsfor a common pattern of updating one of the completions for a PNC/FAC and fixing up the effects.