This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Don't purge bindings when execution leaves scope #2136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release notes: None For historical and apparently no longer needed reason, we used to forget about modified bindings when execution leaves scopes. However, this means that the binding no longer properly participates in state tracking. While by itself, it didn't seem to cause much (or any?) harm, it turned out to be a blocker for #2125, where the initial state of a binding becomes important when joining partially leaked bindings.
NTillmann
added a commit
that referenced
this pull request
Jun 20, 2018
(Still needs #2136 to work.)
hermanventer
approved these changes
Jun 20, 2018
There was a problem hiding this comment.
@hermanventer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
NTillmann
added a commit
that referenced
this pull request
Jun 20, 2018
(Still needs #2136 to work.)
|
Don't know if it was expected, but this commit makes the build 3 times slower for our internal bundle in my testing. That makes it significantly more difficult for me to extract isolated small test cases because it kills my iteration speed. |
|
I'm afraid I just forgot about it. It looks like we'll have to resurrect something like this after all. I'll have a look at it. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2018
Summary: Release note: none This reverses PR #2136, which Dan has noted to lead to a 3x slowdown for an internal bundle. In order to fix the problem that Nikolai's PR addressed, the original code has been modified to not purge any local bindings that could possibly have been captured in a closure. I expect that most effects will not be in a context that contains a closure, so this should help. It would be nice, however, to get some feedback on whether this is actually the case. Closes #2152 Differential Revision: D8617877 Pulled By: hermanventer fbshipit-source-id: 8e907ba1dded0428388fd42132658555e3b8e82e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: None
For historical and apparently no longer needed reasons,
we used to forget about modified bindings when execution
leaves scopes.
However, this means that the binding no longer properly participates
in state tracking, which is conceptually dubious.
While by itself, it didn't seem to cause much (or any?) harm,
it turned out to be a blocker for #2125, where the initial state
of a binding becomes important when joining partially leaked bindings.