This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Adding --instantRender mode. #2178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release notes: None Tweaking some behaviors to help with Instant Render automation. This leaves behind some TODOs in the code, but unblock me for now.
trueadm
reviewed
Jun 28, 2018
src/utils/HeapInspector.js
Outdated
| @@ -87,13 +87,20 @@ export class HeapInspector { | |||
| return HeapInspector._integrityDescriptors[this.getTargetIntegrityCommand(val)]; | |||
| } | |||
|
|
|||
| static isLeaf(val: Value): boolean { | |||
| static isLeaf(realm: Realm, val: Value): boolean { | |||
There was a problem hiding this comment.
Why not get the realm off the value rather than add it to every call site?
trueadm
approved these changes
Jun 28, 2018
cblappert
approved these changes
Jun 28, 2018
There was a problem hiding this comment.
@NTillmann is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: None
Tweaking some behaviors to help with Instant Render automation.
This leaves behind some TODOs in the code, but unblock me for now.