Adds a flag for Array.prototype method nested optimized functions #2404
Conversation
scripts/test-runner.js
Outdated
| @@ -363,6 +363,7 @@ function runTest(name, code, options: PrepackOptions, args) { | |||
| internalDebug: true, | |||
| serialize: true, | |||
| uniqueSuffix: "", | |||
| arrayNestedOptimizedFunctionsEnabled: true, | |||
There was a problem hiding this comment.
This I find confusing. A better way would be to have tests that need it and work carry some special annotation like // arrayNestedOptimizedFunctionsEnabled.
There was a problem hiding this comment.
I thought it would be better to have it on by default in tests so we can catch bugs earlier, but I don't feel strongly and can change this.
There was a problem hiding this comment.
And once not on by default in the serializer, can you also add the test from #2398 as a regression test?
…sted-optimized-functions
…sted-optimized-functions
|
LGTM. Can you also add the test from #2398 as a future regression test? It passes today without the flag being set. |
|
@NTillmann That test was already added and fixed as part of another PR. |
There was a problem hiding this comment.
trueadm is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fixes #2151 #2222 #2279 #2393 #2399 #2404 #2411 #2414 #2415 Added a fuzz testing tool Added test cases Turn crash in JSON.stringify into a diagnostic Adds a `arrayNestedOptimizedFunctionsEnabled` flag to enable nested optimized functions derived from Array.prototype methods (like `map`) and Array.from Refactor assignment on partial or possibly deleted property Rewrote the joining logic to always do a full join at every join point Removed last remnants of delayUnsupportedRequires Reviewed By: cblappert Differential Revision: D9349841 fbshipit-source-id: 74a16dbb015777d59d23fdfde77abbe2489c292a
Release notes: adds a
arrayNestedOptimizedFunctionsEnabledflag to enable nested optimized functions derived from Array.prototype methods (likemap) and Array.fromThis PR puts the existing (unstable) work for Array prototype methods behind a flag. The flag is enabled by default in React and serializer tests.