This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Revert typed descriptors and printer #2508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
force-pushed
the
reverttypedescriptors
branch
from
c0ddd8d
to
2eb24e8
Compare
There was a problem hiding this comment.
sebmarkbage has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
trueadm
approved these changes
Aug 30, 2018
NTillmann
approved these changes
Aug 30, 2018
sebmarkbage
added a commit
to sebmarkbage/prepack
that referenced
this pull request
Aug 30, 2018
This was previously reverted by facebookarchive#2508. Time to recommit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: reverted typed descriptors
23c5da5
and
2b68c6e