This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fixing handling of stack overflows. #2553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release notes: User-level stack overflows no longer crash Prepack. This fixes #2552, and actually a bit more: - We used to piggy-back on `pushContext` to count stack frames. However, there is no one-to-one correspondance of calls and context, so that wasn't a very good proxy. (In fact, there seem to be calls that don't push a context.) So we now count calls and constructs explicitly. - Instead of just throwing a `FatalError` when the stack space is exceeded, which in turn causes an invariant violation since there must not be a `FatalError` thrown without a compiler diagnostics having beein issue. Now there is a regular error code PP0045. Added error handler regression test.
NTillmann
commented
Sep 17, 2018
| @@ -258,7 +258,7 @@ export class Realm { | |||
|
|
|||
| this.start = Date.now(); | |||
| this.compatibility = opts.compatibility !== undefined ? opts.compatibility : "browser"; | |||
| this.maxStackDepth = opts.maxStackDepth || 225; | |||
| this.remainingCalls = opts.maxStackDepth || 112; | |||
There was a problem hiding this comment.
Had to reduce default maximum a bit to ensure that we don't run out of default node.js space before running out of default Prepack stack space.
hermanventer
approved these changes
Sep 17, 2018
There was a problem hiding this comment.
NTillmann is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: User-level stack overflows no longer crash Prepack.
This fixes #2552, and actually a bit more:
pushContextto count stack frames. However, there is no one-to-one correspondance of calls and context, so that wasn't a very good proxy. (In fact, there seem to be calls that don't push a context.) So we now count calls and constructs explicitly.FatalErrorwhen the stack space is exceeded, which in turn causes an invariant violation since there must not be aFatalErrorthrown without a compiler diagnostics having beein issue. Now there is a regular error code PP0045.Added error handler regression test.