Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Error for in with abstract #733

Closed
wants to merge 4 commits into from
Closed

Error for in with abstract #733

wants to merge 4 commits into from

Conversation

hermanventer
Copy link
Contributor

Give a more detailed error when the in operation is not safe to do at Prepack time.

@@ -59,6 +59,10 @@ export default class ProxyValue extends ObjectValue {
this.realm = realm;
}

isSimple(): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@facebook-github-bot
Copy link

@hermanventer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants