This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Error messages for ++ and -- #749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTillmann
reviewed
Jun 22, 2017
src/evaluators/UpdateExpression.js
Outdated
| } | ||
| } | ||
| oldExpr.throwIfNotConcrete(); | ||
| invariant(oldExpr instanceof ConcreteValue); |
There was a problem hiding this comment.
Why is this true? Is there no other unary operator but ++ and --?
There was a problem hiding this comment.
There are no update operators other than ++ and --, but good point, the if statement in line 39 is redundant in that case. I was seduced by the old code.
NTillmann
approved these changes
Jun 23, 2017
cblappert
approved these changes
Jun 25, 2017
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 26, 2017
Summary: Complain if the operand might be a badly behaved abstract value. [PP0008 might be a symbol or an object with an unknown valueOf or toString or Symbol.toPrimitive method](https://github.com/facebook/prepack/wiki/PP0008) Closes #749 Differential Revision: D5320843 Pulled By: hermanventer fbshipit-source-id: 37f7fa789430109899c2cfa00ce50f7c7e1cc6ec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complain if the operand might be a badly behaved abstract value.
PP0008 might be a symbol or an object with an unknown valueOf or toString or Symbol.toPrimitive method