This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Allow more than one input file for Prepack #776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTillmann
approved these changes
Jul 3, 2017
src/prepack-standalone.js
Outdated
| if (!serialized) { | ||
| throw new FatalError(); | ||
| } | ||
| return serialized; | ||
| } | ||
|
|
||
| /* deprecated: pelase use prepackString instead. */ |
src/prepack-standalone.js
Outdated
| initializeGlobals(realm); | ||
|
|
||
| if (options.serialize || !options.residual) { | ||
| let serializer = new Serializer( |
There was a problem hiding this comment.
Indentation looks fine. Prettier will fix that too...
src/prepack-standalone.js
Outdated
| sourceMapContents: JSON.stringify(serialized.map) }]; | ||
| let result = realm.$GlobalEnv.executePartialEvaluator(residualSources, options); | ||
| if (result instanceof AbruptCompletion) throw result; | ||
| return (result: any); |
There was a problem hiding this comment.
This any-cast makes me sad. Is it really needed?
There was a problem hiding this comment.
It is, due to a bug/limitation in Flow. I'll change this to a $FlowFixMe comment.
|
@hermanventer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually need at least two files: 1) the environmental model and 2) the bundle to be Prepacked.
In general, there is no good reason to not allow as many files as the caller wants.
To make this not be a breaking chance, I've added a new API for this: prepackSources.
Further complications result from working around a bug in Babel and not increasing the module cycle length for Flow.