This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Temporary fix for module tracer by disabling rewrite #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTillmann
reviewed
Jul 24, 2017
| for (let [loc, error] of errors) { | ||
| foundFatal = foundFatal || error.severity === "FatalError"; |
There was a problem hiding this comment.
Look 20 lines up --- same code. Probably should get same treatment.
NTillmann
approved these changes
Jul 24, 2017
| this.modules.initializedModules.set(id, value); | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
What's with the commented out code?
There was a problem hiding this comment.
Its the new code that figures out when modules are initialized or not, but it doesn't quite work, I'll uncomment it in the next PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added regression test and re-enabled resolve initialized modules.
Also, fixed bug in cli.