This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Catch fatal errors in visitName. #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTillmann
reviewed
Aug 3, 2017
src/serializer/visitors.js
Outdated
| @@ -98,13 +99,25 @@ export let ClosureRefReplacer = { | |||
| }, | |||
| }; | |||
|
|
|||
| // todo: make a test case that throws a FatalError when calling this. First try a residual function with a reference | |||
There was a problem hiding this comment.
Looks like you did the todo?
NTillmann
reviewed
Aug 3, 2017
src/serializer/visitors.js
Outdated
| true | ||
| ); | ||
| } catch (e) { | ||
| if (!(e instanceof FatalError)) throw e; |
There was a problem hiding this comment.
tryQuery is used from a few more places. I think the whole error-handling logic should move into tryQuery.
NTillmann
approved these changes
Aug 4, 2017
|
@hermanventer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introspection errors no longer show up as completions, so any time we evaluate a node that might cause an introspection error, we should expect to catch and handle a FatalError.
Also tweaked package.json to allow longer stack traces when running test-serializer and tweaked test-internal to output error messages that do not have associated source locations. (The latter should not happen in practice but could happen when things go wrong.)