Skip to content

Commit

Permalink
Escalate log level failing to create streams.
Browse files Browse the repository at this point in the history
Summary: With stream updates this should ideally never happen.

Reviewed By: sharmafb, lnicco

Differential Revision: D21435983

fbshipit-source-id: a76b60bc6de40e7094ea6b2f204ccfa487caf90d
  • Loading branch information
mjoras authored and facebook-github-bot committed May 7, 2020
1 parent a0a68d0 commit ad92ccc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion proxygen/lib/http/session/HQDownstreamSession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ HQDownstreamSession::newPushedTransaction(
// NOTE: should be stored in the transaction
// NOTE: should be cleaned up when the transaction is closed
if (!pushStreamId) {
VLOG(3) << __func__ << " failed to create new unidirectional stream";
VLOG(2) << __func__ << " failed to create new unidirectional stream";
SET_PROXYGEN_ERROR_IF(error, ProxygenError::kErrorCreatingStream);
return nullptr;
}
Expand Down
2 changes: 1 addition & 1 deletion proxygen/lib/http/session/HQSession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2328,7 +2328,7 @@ HQSession::newTransaction(HTTPTransaction::Handler* handler) {
// TODO stream limit handling
auto quicStreamId = sock_->createBidirectionalStream();
if (!quicStreamId) {
VLOG(3) << __func__ << " failed to create new stream: " << this;
VLOG(2) << __func__ << " failed to create new stream: " << this;
return nullptr;
}

Expand Down

0 comments on commit ad92ccc

Please sign in to comment.