Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags transferred when selecting multiple features #1493

Open
atiannicelli opened this issue Jul 17, 2024 · 2 comments
Open

Tags transferred when selecting multiple features #1493

atiannicelli opened this issue Jul 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@atiannicelli
Copy link

Description

When I select two buildings (actually a building and a building part) I see where there are collisions in the tags, but if one of the features doesn't have a tag at all it doesn't indicate that. If I click on that tag then it silently transfers that tag to the feature that didn't have it. I would have expected it to say that there are multiple values for the tag; something and 'unset' or NULL). You can see that in my attached video that:

  1. the order of selecting a building part first vs building first has different behavior.
  2. All the values from the first selected feature are listed as though they are shared between the two feature even though they are not. If one is clicked then that tag is silently attached to the other.

Screenshots

Screen.Recording.2024-07-17.at.10.00.16.AM.mov

Version

2.3.1

What browser are you seeing the problem on? What version are you running?

Chrome v126.0

The OS you're using

mac

Steps to reproduce

  1. Select a building that has a bunch of tags like w261256050
  2. Then select a building part that doesn't have many parts like w1302028017
  3. observe that any of the tags assigned to the building that are not on the part do not indicate a tag collision.
  4. observe that clicking on one of those tags assigns it to the part.

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=21.19/37.78908/-122.41919&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w1043338399&photo_overlay=streetside

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36

@atiannicelli atiannicelli added the bug Something isn't working label Aug 5, 2024
@atiannicelli
Copy link
Author

Just wondering if this is clear. It could potentially cause incorrect tags to be added to features.

@bhousel
Copy link
Contributor

bhousel commented Oct 4, 2024

Just wondering if this is clear. It could potentially cause incorrect tags to be added to features.

I think so - I can see how the tags presented to the user can be confusing..
If one feature has the tag set, and the other feature has it not set, that should be considered "Multiple Values".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants