Integrate latest FBSDK on iOS and JS #541
Conversation
|
Awesome! Will test it with other iOS app before the end of the day. |
|
I ran into build issues when trying. At first it was a bolt thing which got resolved after |
|
My branch doesn’t have code that depend on `RCTComponentEvent`. I think you
aren’t building my branch directly. 🙂
I did ran into this issue on the `master` branch. Someone accidentally
merged a feature that was waiting for `RCTComponentEvent` to be released.
That is why it doesn’t build and that is why I based my changes off of
`0.9.0` because that tag doesn’t depend on that unreleased feature.
Maybe you merged my branch locally and tried to build that way? In that
case it would fail with the error you mentioned. My branch alone shouldn’t
fail with that error.
…On Wed, Jun 12, 2019 at 7:33 PM Simon Bengtsson ***@***.***> wrote:
I ran into build issues when trying. At first it was a bolt thing which
got resolved after pod deintegrate && pod install. Then it was an issue
about 'React/RCTComponentEvent.h' file not found. Got the same when
running the official master branch though (#493
<#493>). You didn't
run into this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#541>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACHTZGJL5BCRNL5FJ7AHMVTP2EXPJANCNFSM4HXDREUA>
.
|
|
You are right! My mistake was specifying |
|
Those must be valid errors. I haven’t integrated the changes in ShareKit, I
was hoping it would just work. I will write a comment here when I’ve done
that too. 🤓
Thanks for checking.
…On Thu, Jun 13, 2019 at 12:43 AM Simon Bengtsson ***@***.***> wrote:
You are right! My mistake was specifying
github:redcancode/react-native-fbsdk instead of
github:redcancode/react-native-fbsdk#integrate-latest-fbsdk. Everything
seems to be working in our project.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#541>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACHTZGJFZAQGXVX2OEQBBOLP2F3ZJANCNFSM4HXDREUA>
.
|
|
I was a bit quick in posting that comment, wrote on updated comment above. The issues mentioned went away after first fixing compile issues from upgrading to v5 of the native sdk in our native app before upgrading react-native-fbsdk. |
|
Those are valid errors. If you pull in the |
|
@redcancode Thanks a lot for working on this! I just updated the example app in the repo to target RN 0.60 which fixes the Sadly it won't be backwards compatible but users are free to stay on an older version until RN can be updated. If you are okay with that I can merge this PR as is and work on fixing the remaining errors in |
|
@janicduplessis I'm not ready with this PR yet. I've made progress with the integration of I think it would be a great idea to create a new branch for this effort called something like What do you say? 🙂 |
|
@redcancode I think a good way to split this work is you can make the required changes for iOS / JS and I'll take care of android. |
|
Also if you want to make testing easier you can try the new example app, the instructions to run it are here |
|
@janicduplessis Okay let's use I will create another PR about |
- Remove deprecated login behaviors - Rename FBSDKLoginManagerRequestTokenHandler - Simplify loginWithPermissions call - Implmenet access token changes - Rename FBSDKGraphRequestHandler - Remove deprecated AppInviteDialog - Remove previewPhoto from VideoContent - Correct FBSDKShareOpenGraphAction instance creation - Remove deprecated LikeView
redcancode
force-pushed
the
integrate-latest-fbsdk
branch
from
78a6463
to
fa450bb
Compare
redcancode
changed the title
|
@janicduplessis i've finished with all the changes. also updated the original PR description. the only problem is that i can't build the example app because of some pods path issue. i will solve that later this week. i was able to build my app with these changes though |
|
Actually lets just merge this and you can address the feedback in a followup. I'll work on updating the login method to have a single one instead of loginWithReadPermissions and loginWithPublishPermissions. |
There have been some breaking changes in the native FBSDK this year which prevents us from using the latest version. I've decided to help the problem and integrate the latest changes with this pull request.
Currently I've integrated the iOS FBSDK changes. My app builds and runs and I was able to login and obtain an access token. I'm not finished with these integrations.
Here are the list of things I want to do:
After I've done with these items this PR should be ready for a real review and consideration to merge it and support the latest FBSDK on both platforms.
It would be great if you could try this out and confirm that it works for you too. Everything should work on iOS.
I've started my branch from the latest published version which is
0.9.0. I did this on purpose becausemasteris broken currently due toRCTComponentEventstill being unpublished.Your feedback would be greatly appreciated. 🙂
[Update-2019-June-14] This PR has been repurposed into integrating the latest FBSDK on iOS and JS only. The android part has been done in PR #546
Fixes #533