-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorial.md #2546
Update tutorial.md #2546
Conversation
Changed this.props.{NAME} by {this.props.NAME}
Hi @HughRdgz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for react-native ready! Built with commit e519d37 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HughRdgz, can you explain why you want to change this note? Currently inline code in there looks fine to me. {NAME}
is referring to the user defined prop, used here as placeholder, the rest of chain should remain unchanged no matter which name has been chosen.
maybe I got confused by the brackets, since these are used in code for interpolation. |
Template literals requires a dollar sign before the curly brackets: @HughRdgz Maybe we can replace the brackets with other character, but both parentheses |
What do you thing about angle brackets? |
@HughRdgz We can try that, can you update the PR and include change also to the base docs at I will look through the code how often we use this format and if any other notes should be changed too, to preserve the consistency across the website. |
@HughRdgz It looks like this was the only one place on the website where such placeholder format has been used. I have also received feedback, that using angle brackets will resemble too much of JSX syntax, so at this moment of time I have changed the placeholder name to more descriptive one, which I hope will also make it more obvious, that it's just a pseudo-code example. |
Changed this.props.{NAME} by {this.props.NAME}