Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ScrollView] Warning: ScrollView doesn't take rejection well - scrolls anyway #1501

Closed
magicismight opened this issue Jun 3, 2015 · 97 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@magicismight
Copy link
Contributor

I put a ScrollView inside another ScrollView.
When I scrolled,It will give a warning: Warning: ScrollView doesn't take rejection well - scrolls anyway ,and sometimes the ScrollView inside will jump to the top or bottom.

@rxb
Copy link
Contributor

rxb commented Jun 4, 2015

Is it a vertical + horizontal combination or two ScrollViews scrolling on the same axis?

@marcshilling
Copy link

I get this warning randomly even without nested ScrollViews. No clue what it means.

@piyushchauhan2011
Copy link

Ohhh I'm also getting this warning don't know why 😞

@silentcloud
Copy link

I'm also getting this warning

@eljago
Copy link

eljago commented Jun 15, 2015

I'm getting this when scrolling vertically a ListView that's inside an horizontal ScrollView

@sghiassy
Copy link

The same issue is posted here as well: #41

@felixakiragreen
Copy link
Contributor

👍

@jasonmerino
Copy link

I'm getting this issue when nesting a TextInput inside a ListView. When scrolling most of the time I don't get the warning, but when I start the scroll with the pointer (this is in the simulator, haven't tried on device yet) on the TextInput it gives me the warning.

@Joshuabaker2
Copy link

I am also seeing this issue. I have a custom 'swipe to delete' for the rows which has a horizontal swipe inside a vertical ListView. If I move up or down at all while this happens, it scrolls. Even with setting:

onPanResponderTerminationRequest: () => false

@ryanmcdermott
Copy link

I get this issue with a <ListView> inside a <ScrollView>

@patoroco
Copy link
Contributor

one more here. I have two ListViews inside a Scroll (I'm using react-native-scrollable-tab-view component)

@xiekw2010
Copy link

@magicismight The jump reason is than you should set this automaticallyAdjustContentInsets={false}

@pengzekuan
Copy link

111

@pengzekuan
Copy link

when put a props dynamic in the scrollview it happend

@IlyasM
Copy link

IlyasM commented Nov 20, 2015

+1

5 similar comments
@nowaits
Copy link

nowaits commented Nov 26, 2015

+1

@chenxiaohu
Copy link

+1

@wuchu
Copy link

wuchu commented Dec 6, 2015

+1

@jadsonlourenco
Copy link

+1

@niftylettuce
Copy link
Contributor

+1

@bitQ2019
Copy link

+1
It may because render a scrollview in another list/scroll view!
And textInput is actually scrollview indeed!
fix!

@iZaL
Copy link

iZaL commented Dec 15, 2015

👍

@adriansdev
Copy link

@MENQ is right, if you drag a scrollview by press and drag within a multiline textInput then you get the error

@javache
Copy link
Member

javache commented Dec 16, 2015

We can probably apply the fix in 67bf0f1 to scrollviews as well. If you have a test case for this, please try it and send a PR.

@jadsonlourenco
Copy link

@javache I have tested this PR few days ago, I think that solve this problem, but not: Warning: ScrollView doesn't take rejection well - scrolls anyway

@austin1030
Copy link

I tried many methods to have nested ScrollView and avoid warning message but I just can't seems to find a correct way. So, until there is one, I just decided to comment out where the warning message gets called in node_modules/react-native/Libraries/Components/ScrollResponder.js (v 0.17.0) line 203.

scrollResponderHandleResponderReject: function() {
    //warning(false, "ScrollView doesn't take rejection well - scrolls anyway");
},

@alex-gvozden
Copy link

I get this "ScrolView doesn't take rejection well"
if I have TextInput inside ScrollView
with just Text it works

so, this is no warning
<View> <Text>Test</Text> </View>

this is with warning
<View> <TextInput style={{height: 40, borderColor: 'gray', borderWidth: 1}} onChangeText={(text) => this.setState({text})} value={this.state.text} /> </View>

@jblack10101
Copy link

+1

@brentvatne
Copy link
Collaborator

Can someone provide a repo where this happens for @javache? Just create a small example and put it up on Github. Thanks!

@jblack10101
Copy link

@alexprice1
Copy link

I don't want to add noise here, but I noticed I am seeing this issue on iOS if I have a Picker inside the ScrollView. I am guessing this is an issue with there being a scrollable component within this scrollView

@noneven
Copy link

noneven commented Mar 15, 2016

+1 and it's not just the warning. If you have a form rendered in a ScrollView, then when you try to move from one TextInput to the next by tapping, the warning fires, and the next field doesn't get focus. You have to tap twice. It makes forms very annoying to use.

@tbolt
Copy link

tbolt commented Mar 18, 2016

+1

4 similar comments
@hvsy
Copy link

hvsy commented Mar 21, 2016

+1

@hehex9
Copy link

hehex9 commented Mar 21, 2016

+1

@yimiaodaren
Copy link

+1

@cemolcay
Copy link

+1

@Xwoder
Copy link

Xwoder commented Mar 25, 2016

I notice that, if you put a ScorllView/TextInput in another ScrollVIew, the warning will appear.

@d-johan
Copy link

d-johan commented Mar 25, 2016

+1

2 similar comments
@Rusya13
Copy link

Rusya13 commented Mar 28, 2016

+1

@rilyu
Copy link

rilyu commented Mar 31, 2016

+1

@yury-sannikov
Copy link

+1

@gre
Copy link
Contributor

gre commented Mar 31, 2016

hey.
Please stop commenting "+1".

github have a 👍 feature now, just upvote the first issue message. that way, issues can be sorted by 👍

screen shot 2016-03-31 at 23 35 31

and if you just want to receive notifications of this issue, there is a Subscribe button on the right too

screen shot 2016-03-31 at 23 36 22

Thanks

@baloo
Copy link

baloo commented Mar 31, 2016

@gre +1

ghost pushed a commit that referenced this issue Apr 7, 2016
Summary:I get this warning in cases when nothing went wrong.

Not sure what I can do about the warning. I placed a few sliders in a ScrollView and everything works as expected, so the warning is very confusing.

Lots of people have been hitting the warning and getting confused by it as well:
- #1501
- https://productpains.com/post/react-native/scrollview-warning-scrollview-doesnt-take-rejection-well-scrolls-anyway (it's one of the [highest rated](https://productpains.com/product/react-native?tab=top) issues).

Reviewed By: sahrens

Differential Revision: D3138736

fb-gh-sync-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
fbshipit-source-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
@mkonicek
Copy link
Contributor

mkonicek commented Apr 7, 2016

Hey guys, I've just removed the warning :) Context: 5f77f15

Lots of people report something similar to this:

I get this warning randomly even without nested ScrollViews. No clue what it means.

I completely agree and don't think the warning is very useful. I'm closing this issue (the warning won't show up anymore in 0.24 and above).

Regarding the second part of the issue description:

and sometimes the ScrollView inside will jump to the top or bottom

Please report that separately (with a video!) and ideally send a pull request with a fix.

@mkonicek mkonicek closed this as completed Apr 7, 2016
ide pushed a commit that referenced this issue Apr 7, 2016
Summary:I get this warning in cases when nothing went wrong.

Not sure what I can do about the warning. I placed a few sliders in a ScrollView and everything works as expected, so the warning is very confusing.

Lots of people have been hitting the warning and getting confused by it as well:
- #1501
- https://productpains.com/post/react-native/scrollview-warning-scrollview-doesnt-take-rejection-well-scrolls-anyway (it's one of the [highest rated](https://productpains.com/product/react-native?tab=top) issues).

Reviewed By: sahrens

Differential Revision: D3138736

fb-gh-sync-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
fbshipit-source-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
@mkonicek
Copy link
Contributor

mkonicek commented Apr 7, 2016

To clarify, here's what the warning actually means. You can see I manage to scroll the ScrollView even when dragging the slider:
https://vid.me/t5hY

This only happens on iOS and someone should fix that. But the warning pops up in many normal cases too, like when flinging the slider vertically. In this case scrolling is good but the warning still pops up.

It's not clear to me whether this GitHub issue was about the warning itself or about the ScrollView not taking rejection well. The warning was not actionable and it is gone now, let's discuss the ScrollView not taking rejection well separately (ideally someone with iOS knowledge could send a pull request with a fix).

@GantMan
Copy link
Contributor

GantMan commented Apr 13, 2016

Do you think it's wise to do this to scrollview? People won't understand.
image

...poor poor scrollview

@Emilios1995
Copy link
Contributor

@mkonicek Thanks, but did your commit get merged? I'm still getting the warning in 0.24

@grayboxpdx
Copy link

@mkonicek Same here, I'm still getting the warning in 0.24.1

@creeperyang
Copy link

@chirag04 not work. More details?

zebulgar pushed a commit to nightingale/react-native that referenced this issue Jun 18, 2016
Summary:I get this warning in cases when nothing went wrong.

Not sure what I can do about the warning. I placed a few sliders in a ScrollView and everything works as expected, so the warning is very confusing.

Lots of people have been hitting the warning and getting confused by it as well:
- facebook#1501
- https://productpains.com/post/react-native/scrollview-warning-scrollview-doesnt-take-rejection-well-scrolls-anyway (it's one of the [highest rated](https://productpains.com/product/react-native?tab=top) issues).

Reviewed By: sahrens

Differential Revision: D3138736

fb-gh-sync-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
fbshipit-source-id: 601b8dfc275a14dff6f17a7903c65bd8347a73e9
@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests