Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput breaks system spell check on Samsung devices (S8) #15590

Closed
george-cz opened this issue Aug 21, 2017 · 3 comments
Closed

TextInput breaks system spell check on Samsung devices (S8) #15590

george-cz opened this issue Aug 21, 2017 · 3 comments
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@george-cz
Copy link

Is this a bug report?

yes

Have you read the Contributing Guidelines?

yes

Environment

  1. react-native -v: 0.46.4
  2. node -v: v6.9.5
  3. npm -v: 3.10.10
  4. yarn --version: 0.21.3

Then, specify:

  • Target Platform: Android (Samsung)
  • Development Operating System: MacOS
  • Build tools: using create-react-native-app and Expo

Steps to Reproduce

(Write your steps here:)

  1. Use Samsung S8 with latest firmware (should be reproducible S6 and above)
  2. Enable Spell Checker in the phone menu
  3. Create controlled <TextInput value={this.state.val} onChangeText={this.onChange} editable={true} spellCheck={true} />
  4. Run the app and input some obviously wrong spelled text, (e.g. aiefsjaliesfj or adsjfaleifjlaisef :))

Expected Behavior

I would expect the text input to underline the invalid text with red line, allowing me to click it and select from close correctly spelled candidates.

Actual Behavior

The red line just flashes and then disappears, breaking the system spell check feature.

Reproducible Demo

https://snack.expo.io/B1-6Lw_uW

Fire this up and insert some text.

@chirag04
Copy link
Contributor

The red line just flashes and then disappears, breaking the system spell check feature.

spell check is ios only.

@george-cz
Copy link
Author

Well even though the prop might not be supported, TextInput still breaks the native functionality.

@george-cz george-cz changed the title SpellCheck broken on Samsung devices (S8) TextInput breaks spell system check on Samsung devices (S8) Aug 23, 2017
@george-cz george-cz changed the title TextInput breaks spell system check on Samsung devices (S8) TextInput breaks system spell check on Samsung devices (S8) Aug 23, 2017
@stale
Copy link

stale bot commented Oct 22, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 22, 2017
@stale stale bot closed this as completed Oct 29, 2017
@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants