-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the Animated.Flatlist or Animated.ScrollView to animate an Animated.View is not smooth #15769
Comments
I can reproduce this, seems like binding Doing some bisecting on Snack, seems like this broke between Expo 18 (React Native 0.45) and Expo 19 (React Native 0.46). Between those versions, seems like there were two commits landed to Animated, both by @janicduplessis:
Neither of them seems to be the obvious candidate. The diff is v0.45.1...v0.46.4#diff-f048d92ca0be679bc38d38147b311100 Additional steps to reproduce:
|
There has been a regression with scroll events on Android. e964a7f fixes it, I'll try to get it cherry picked in the next 0.48 patch. |
This also happens on RN v0.46.4 ios |
+1 I am experiencing this behavior on iOS as well. I also tried out setting scrollEventThrottle to 16. But the experience was still jittery. |
I think this is solved with the new updates. I have tested this both with the ScrollView and FlatList, and it's fine now. @jevakallio Can you please confirm? So that I can close this issue? |
Looks good now. |
@KakarN what is your version of react-native? |
@KakarN Which version are you referring to? I would like to update as well since we are facing the issues too. |
@MSSPL-PiyaleeMaiti @bitcrumb hi! I am actually using expo. And when this question was asked, the expo SDK was 20 which was based on react native 0.47 (which had the android regression issue). But yesterday expo released SDK 21 which is based on react native 0.48, (and the regression was fixed). Now I don't see any regression issue and the scrolling and animation are working smoothly. |
Thanks for the quick feedback. We updated our React Native version to 0.48.3 and it is indeed resolved. Thanks for pointing this out to us! |
@bitcrumb No problem! |
The code in the expo link you attached saved me hours of googling and got me started quickly. Thank you! |
Is this a bug report?
Yes
Environment
react
: 16.0.0-alpha.12,react-native -v
: ^0.47.0,node -v
: v7.7.3npm -v
: 4.1.2yarn --version
: 0.21.3Target Platform:
iOS and Android
Development Operating System:
macOS
Build tools:
expo
Steps to Reproduce
onScroll
function to update the animated value.Expected Behavior
I saw this issue of how using
scrollEventThrottle
helps the smoothness. So I thought using FlatList would be smooth.Actual Behavior
However, when scrolling the FlatList, the animated view does animate, but the animation is not smooth. If your scroll while pressing, it's smooth. But if you scroll and leave the finger, it's jumpy ( I don't know how to describe it. Sorry). The animated view (Header) animation is not smooth at all.
Reproducible Demo
Snack link for animated FlatList and animated header
Animated Flat List
Update
So, I tried to implement the same functionality using ScrollView. However, I think, its even worse using ScrollView when compared to FlatList.
Here is the expo snack demo: Animated ScrollView Header
I think I need to mention how I got here at the first place. So, I tried to implement this by a very nice tutorial in Medium, and also by watching this awesome youtube react conf viedo by @brentvatne . However, the exact code used on youtube video has the same effect. Also, on the Medium tutorial, the author has given a Link to his expo Animated header link, which works very smoothly on the device. But the same code doesn't work smoothly when I copy paste the code and test it. So, I think the problem is with the react or react native version. I will update if I have any new update. Thank you.
The text was updated successfully, but these errors were encountered: