Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTWebSocket.m (2 issues) #8975

Closed
ozguruksal opened this issue Jul 22, 2016 · 3 comments
Closed

RCTWebSocket.m (2 issues) #8975

ozguruksal opened this issue Jul 22, 2016 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ozguruksal
Copy link

ozguruksal commented Jul 22, 2016

XCode version 7.3.1 is fine but if I use version 8.2(beta) instead, then the XCode reports two issues:

  1. /pathTo/myProject/node_modules/react-native/Libraries/WebSocket/RCTSRWebSocket.m:494:3: Ignoring return value of function declared with warn_unused_result attribute
  2. /pathTo/myProject/node_modules/react-native/Libraries/WebSocket/RCTSRWebSocket.m:1334:5: Ignoring return value of function declared with warn_unused_result attribute

If I comment out the following two lines from "RCTWebSocket.m", the build succeeds:
SecRandomCopyBytes(kSecRandomDefault, keyBytes.length, keyBytes.mutableBytes);
SecRandomCopyBytes(kSecRandomDefault, sizeof(uint32_t), (uint8_t *)mask_key);

@zhileichen
Copy link

zhileichen commented Jul 24, 2016

Specifically, it caused by the llvm compiler flag -Werror, means turn warnings into errors, which might start work in later llvm 8.0, you can removed it in the build settings of RCTWebSocket target.

@TimBroddin
Copy link

I posted a fix here:
#8584

@javache
Copy link
Member

javache commented Aug 16, 2016

Fixed by 2f78852

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants