[NavigatorIOS] Fix pop method to properly refresh the navigatorBar

[jaysalvat]

When using nativator.pop() the navigatorBar doesn't refresh properly if we change navigationBarHidden.

Current result:

When navigator.pop() is called, the navbar doesn't show up, even avec navigationBarHidden set back to true. See between Statusbar and Movie poster in the example below.

// Not actually updating the indices yet until we get the native
// `onNavigationComplete`.
updatingAllIndicesAtOrBeyond: null,

https://github.com/facebook/react-native/blob/master/Libraries/Components/Navigation/NavigatorIOS.ios.js#L510-L512

Expected result (after fix)

The View need to be refreshed in pop method anyway.

updatingAllIndicesAtOrBeyond: this.state.requestedTopOfStack - n,

Now, navbar appears properly.

[sahrens]

@ericvicenti, @ide: Any idea if this will cause problems? The previous code with the comment was pretty clear....

[sahrens]

@ide: just mark as accepted when you think this is good to go and I'll import it.

[ide]

Reading through, this won't cause correctness issues I believe but it may affect performance. Will need to dig in deeper since I'm not very familiar with this code.

[jaysalvat]

Performance is important, but 'm sure we can't afford loosing navbar on pop().

[fender]

+1

I've noticed this bug recently too.

[facebook-github-bot]

@jaysalvat updated the pull request.

[brentvatne]

@facebook-github-bot shipit

[facebook-github-bot]

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/972167456166907/int_phab to review.