Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node 4.x] Update the packager's version check message for Node 4.0 #2547

Closed
wants to merge 1 commit into from

Conversation

ide
Copy link
Contributor

@ide ide commented Sep 3, 2015

Users should use Node 4.0 instead of io.js. This isn't a hard requirement since io.js still works but it's simpler if everyone is on the latest version.

Test Plan: Launch the packager while running io.js 3.3.0 and get the update message.

@ide ide added the packager label Sep 3, 2015
@ide ide mentioned this pull request Sep 3, 2015
5 tasks
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2015
Users should use Node 4.0 instead of io.js. This isn't a hard requirement since io.js still works but it's simpler if everyone is on the latest version.

Test Plan: Launch the packager while running io.js 3.3.0 and get the update message.
@vjeux
Copy link
Contributor

vjeux commented Oct 3, 2015

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1005797092766332/int_phab to review.

@ide ide closed this in ac069aa Oct 3, 2015
@ide ide deleted the node-convergence-check branch October 5, 2015 19:49
MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
Summary: Users should use Node 4.0 instead of io.js. This isn't a hard requirement since io.js still works but it's simpler if everyone is on the latest version.
Closes facebook#2547

Reviewed By: @​svcscm

Differential Revision: D2506388

Pulled By: @vjeux
Crash-- pushed a commit to Crash--/react-native that referenced this pull request Dec 24, 2015
Summary: Users should use Node 4.0 instead of io.js. This isn't a hard requirement since io.js still works but it's simpler if everyone is on the latest version.
Closes facebook#2547

Reviewed By: @​svcscm

Differential Revision: D2506388

Pulled By: @vjeux
cpojer pushed a commit to facebook/metro that referenced this pull request Jan 26, 2017
Summary: Users should use Node 4.0 instead of io.js. This isn't a hard requirement since io.js still works but it's simpler if everyone is on the latest version.
Closes facebook/react-native#2547

Reviewed By: @​svcscm

Differential Revision: D2506388

Pulled By: @vjeux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants