Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix pod install --project-directory=ios failing #37994

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Jun 21, 2023

Summary:

image

pod install --project-directory=ios currently fails when new arch is enabled: react-native-async-storage/async-storage#910

Changelog:

[IOS] [FIXED] - Fix pod install --project-directory=... when New Arch is enabled

Test Plan:

git clone https://github.com/react-native-async-storage/async-storage.git
cd async-storage
gh pr checkout 910
yarn
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=example/ios

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Jun 21, 2023
@analysis-bot
Copy link

analysis-bot commented Jun 21, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,545,460 -412,666
android hermes armeabi-v7a 7,859,634 -359,679
android hermes x86 9,024,364 -447,427
android hermes x86_64 8,878,906 -435,354
android jsc arm64-v8a 9,145,056 -374,007
android jsc armeabi-v7a 8,335,014 -322,577
android jsc x86 9,198,313 -405,292
android jsc x86_64 9,455,901 -394,279

Base commit: b3bb553
Branch: main

facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2023
Summary:
![image](https://user-images.githubusercontent.com/4123478/217618490-4f99e408-1a07-4acf-a05c-e8837562a931.png)

`pod install --project-directory=ios` currently fails when new arch is enabled: react-native-async-storage/async-storage#910

- Patch for 0.71: #37993
- Patch for 0.72: #37994

## Changelog:

[IOS] [FIXED] - Fix `pod install --project-directory=...` when New Arch is enabled

Pull Request resolved: #37992

Test Plan:
```
git clone https://github.com/react-native-async-storage/async-storage.git
cd async-storage
gh pr checkout 910
yarn
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=example/ios
```

Reviewed By: cortinico

Differential Revision: D46966225

Pulled By: cipolleschi

fbshipit-source-id: 00b4650189175c09c9ec928f85d075890ba4c7c1
@tido64 tido64 merged commit 0b96bdc into 0.72-stable Jun 23, 2023
5 checks passed
@tido64 tido64 deleted the tido/fix-codegen-0.72 branch June 23, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants