Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTML5 iframe attributes: seamless, sandbox and srcdoc #1057

Closed
thechriswalker opened this issue Feb 12, 2014 · 4 comments · Fixed by #1067
Closed

Add support for HTML5 iframe attributes: seamless, sandbox and srcdoc #1057

thechriswalker opened this issue Feb 12, 2014 · 4 comments · Fixed by #1067

Comments

@thechriswalker
Copy link

No description provided.

@thechriswalker
Copy link
Author

Actually I see master has srcDoc (wasn't in 0.8.0).

@zpao
Copy link
Member

zpao commented Feb 12, 2014

Want to add them? We're going to cut 0.9 very soon, so if you'd like them in before 0.9.1 whenever that happens, now is the time (also backportable to 0.8.x if we do one)

sophiebits added a commit to sophiebits/react that referenced this issue Feb 13, 2014
@sophiebits
Add seamless and sandbox properties for iframe
d0502cf 
Fixes facebook#1057.
@sophiebits sophiebits mentioned this issue Feb 13, 2014
Merged
@thechriswalker
Copy link
Author

Beat me to it... Thanks!

@sophiebits
Copy link
Collaborator

@thechriswalker So sorry, wasn't sure if you were planning to!

jgebhardt pushed a commit to jgebhardt/react that referenced this issue Feb 15, 2014
@sophiebits @jgebhardt
Add seamless and sandbox properties for iframe
35cbbf6 
Fixes facebook#1057.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add seamless and sandbox properties for iframe sophiebits/react
3 participants
@sophiebits @zpao @thechriswalker