[Flight] Don't drop debug info if there's only a readable debug channel #34304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Flight Client is waiting for pending debug chunks, it drops the debug info if there is no writable side of the debug channel defined. However, it should instead check if there's no readable side defined. Fixing this is not only important for browser clients that don't want or need a return channel, but it's also crucial for server-side rendering, because the Node and Edge clients only accept a readable side of the debug channel. So they can't even define a noop writable side as a workaround.
github-actions
bot
added
the
React Core Team
This is aligning Parcel's browser client with the other ones, and also fixing the missed debug channel change in `createFromReadableStream`.
It's `callback` not `writable`.
eps1lon
reviewed
Aug 27, 2025
packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMNode-test.js
Show resolved
Hide resolved
unstubbable
force-pushed
the
fix-wait-for-referenced-debug-chunks
branch
from
521f26c to
7d79f37
Compare
unstubbable
force-pushed
the
fix-wait-for-referenced-debug-chunks
branch
from
7d79f37 to
458ad5b
Compare
eps1lon
approved these changes
Aug 27, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2025
…el (#34304) When the Flight Client is waiting for pending debug chunks, it drops the debug info if there is no writable side of the debug channel defined. However, it should instead check if there's no readable side defined. Fixing this is not only important for browser clients that don't want or need a return channel, but it's also crucial for server-side rendering, because the Node and Edge clients only accept a readable side of the debug channel. So they can't even define a noop writable side as a workaround. DiffTrain build for [9c2e2b8](9c2e2b8)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 27, 2025
…el (#34304) When the Flight Client is waiting for pending debug chunks, it drops the debug info if there is no writable side of the debug channel defined. However, it should instead check if there's no readable side defined. Fixing this is not only important for browser clients that don't want or need a return channel, but it's also crucial for server-side rendering, because the Node and Edge clients only accept a readable side of the debug channel. So they can't even define a noop writable side as a workaround. DiffTrain build for [9c2e2b8](9c2e2b8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 31, 2025
…el (facebook#34304) When the Flight Client is waiting for pending debug chunks, it drops the debug info if there is no writable side of the debug channel defined. However, it should instead check if there's no readable side defined. Fixing this is not only important for browser clients that don't want or need a return channel, but it's also crucial for server-side rendering, because the Node and Edge clients only accept a readable side of the debug channel. So they can't even define a noop writable side as a workaround. DiffTrain build for [9c2e2b8](facebook@9c2e2b8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 31, 2025
…el (facebook#34304) When the Flight Client is waiting for pending debug chunks, it drops the debug info if there is no writable side of the debug channel defined. However, it should instead check if there's no readable side defined. Fixing this is not only important for browser clients that don't want or need a return channel, but it's also crucial for server-side rendering, because the Node and Edge clients only accept a readable side of the debug channel. So they can't even define a noop writable side as a workaround. DiffTrain build for [9c2e2b8](facebook@9c2e2b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Flight Client is waiting for pending debug chunks, it drops the debug info if there is no writable side of the debug channel defined. However, it should instead check if there's no readable side defined.
Fixing this is not only important for browser clients that don't want or need a return channel, but it's also crucial for server-side rendering, because the Node and Edge clients only accept a readable side of the debug channel. So they can't even define a noop writable side as a workaround.