Skip to content

Conversation

iamsmruti
Copy link
Contributor

@iamsmruti iamsmruti commented Aug 28, 2025

Summary

Update the CodeSandbox CI configuration to use Node 20 instead of Node 18, so that it matches the Node version specified in .nvmrc. This ensures consistency between local development environments and CI builds, reducing the risk of version-related build issues.

Closes #34328

How did you test this change?

  • Verified that .nvmrc specifies Node 20 and .codesandbox/ci.json is updated accordingly.
  • Locally switched to Node 20 using nvm use 20 and successfully ran build scripts for all packages: react, react-dom, react-server-dom-webpack, and scheduler.
  • Confirmed there are no Node 20–specific build errors or warnings locally.
  • CI on the feature branch will now run with Node 20, and all builds are expected to succeed.

@meta-cla meta-cla bot added the CLA Signed label Aug 28, 2025
@iamsmruti iamsmruti force-pushed the update-codesandbox-ci-to-node-20 branch from f5d1cd4 to 1df6bec Compare August 28, 2025 17:25
@iamsmruti
Copy link
Contributor Author

The CI ran successfully with Node v20.12.2. You can see that in the CI logs by scrolling to the top.

Screenshot 2025-08-28 at 11 11 05 PM

@poteto
Copy link
Member

poteto commented Aug 28, 2025

thanks!

@react-sizebot
Copy link

Comparing: 89a803f...1df6bec

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.31 kB 530.31 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 657.78 kB 657.78 kB = 115.66 kB 115.66 kB
facebook-www/ReactDOM-prod.classic.js = 677.76 kB 677.76 kB = 118.94 kB 118.94 kB
facebook-www/ReactDOM-prod.modern.js = 668.19 kB 668.19 kB = 117.26 kB 117.26 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1df6bec

@poteto poteto merged commit 6b49c44 into facebook:main Aug 28, 2025
241 checks passed
EugeneChoi4 pushed a commit to EugeneChoi4/react that referenced this pull request Sep 4, 2025
## Summary
Update the CodeSandbox CI configuration to use Node 20 instead of Node
18, so that it matches the Node version specified in .nvmrc. This
ensures consistency between local development environments and CI
builds, reducing the risk of version-related build issues.

Closes facebook#34328

## How did you test this change?
- Verified that .nvmrc specifies Node 20 and .codesandbox/ci.json is
updated accordingly.
- Locally switched to Node 20 using nvm use 20 and successfully ran
build scripts for all packages: `react`, `react-dom`,
`react-server-dom-webpack`, and `scheduler`.
- Confirmed there are no Node 20–specific build errors or warnings
locally.
- CI on the feature branch will now run with Node 20, and all builds are
expected to succeed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CodeSandbox CI to Node 20 to match .nvmrc

3 participants