[DevTools] Ignore repeated removals of the same IO #34495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
reviewed
Sep 15, 2025
sebmarkbage
reviewed
Sep 15, 2025
| !suspendedBySet.delete(instance) | ||
| (!removedIOInfos.has(ioInfo) && !suspendedBySet.delete(instance)) | ||
| ) { | ||
| throw new Error( |
There was a problem hiding this comment.
You could just check previousSuspendedBy.indexOf(asyncInfo) < i.
There was a problem hiding this comment.
Instead of what? The async info in suspendedBy is unique in this case. It's the IO that's not.
There was a problem hiding this comment.
I see. Then you can do it one level below with a custom loop walking to this index. Still likely faster to check a small set like this in the existing array than even just running the .has(). Let alone allocating and maintaining the set.
sebmarkbage
approved these changes
Sep 16, 2025
sebmarkbage
reviewed
Sep 16, 2025
| if ( | ||
| suspendedBySet === undefined || | ||
| !suspendedBySet.delete(instance) | ||
| (!alreadyRemovedIO && !suspendedBySet.delete(instance)) |
There was a problem hiding this comment.
Ideally we'd check if !suspendedBySet.delete(instance) first before doing the loop so that in the common case when we do succeed in deleting it, there's no reason to check.
sebmarkbage
approved these changes
Sep 16, 2025
eps1lon
deleted the
sebbie/09-15-_devtools_ignore_repeated_removals_of_the_same_io
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternative would be to make
instance.suspendedByunique on IO instead of async info:react/packages/react-devtools-shared/src/backend/fiber/renderer.js
Lines 2833 to 2835 in 47664de