[DevTools] Don't keep stale root instances we never mounted around #34504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Sep 16, 2025
| unmountInstanceRecursively(rootInstance); | ||
| rootToFiberInstanceMap.delete(root); | ||
| flushPendingEvents(root); | ||
| flushPendingEvents(); |
There was a problem hiding this comment.
drive-by fix. flushPendingEvents doesn't actually use any of its arguments.
eps1lon
changed the title
sebmarkbage
approved these changes
Sep 16, 2025
eps1lon
force-pushed
the
sebbie/09-16-_devtools_use_alternate_as_previous_fiber_when_reconciling_root
branch
from
c8833ff to
a387a3f
Compare
eps1lon
deleted the
sebbie/09-16-_devtools_use_alternate_as_previous_fiber_when_reconciling_root
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34495
Follow-up to #34467
We can't reference a Fiber instance that we never fully mounted since we use these Fiber root instances to get the previous Fiber to reconcile against.
Fixes "There should always be an Offscreen Fiber child in a hydrated Suspense boundary." due to attempting to unmount a Fiber that we didn't actually mount and "There should always be a SuspenseNode parent on a mounted instance." because we attempted to update a Fiber instance that never actually went through
mountFiberRecursivelybecause it didn't have any child when we first encountered it.