[DevTools] Don't inline workers for extensions #34508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/09-16-_devtools_don_t_inline_parse_hook_name_worker
branch
from
3e3ed1d to
a08bca1
Compare
|
Comparing: 27b4076...74a26e0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
sebbie/09-16-_devtools_don_t_inline_parse_hook_name_worker
branch
from
a08bca1 to
ec61196
Compare
eps1lon
changed the title
eps1lon
force-pushed
the
sebbie/09-16-_devtools_don_t_inline_parse_hook_name_worker
branch
2 times, most recently
from
cdf65b6 to
eac0b53
Compare
eps1lon
changed the title
eps1lon
force-pushed
the
sebbie/09-16-_devtools_don_t_inline_parse_hook_name_worker
branch
from
a62fabe to
74a26e0
Compare
eps1lon
commented
Sep 17, 2025
Comment on lines
+46
to
+47
| // workers in this bundle, we can sync require the module since it's just a thin | ||
| // wrapper around calling the worker. |
There was a problem hiding this comment.
2kB to be specific
eps1lon
commented
Sep 17, 2025
Comment on lines
+834
to
+839
| - name: Archive Playwright report | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: devtools-playwright-artifacts | ||
| path: tmp/playwright-artifacts | ||
| if-no-files-found: warn |
There was a problem hiding this comment.
Will help debugging CI failures even though that wasn't necessary here. The issue was reproducible locally.
hoxyq
approved these changes
Sep 17, 2025
eps1lon
deleted the
sebbie/09-16-_devtools_don_t_inline_parse_hook_name_worker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source of workers was inlined since workers were introduced in #21902.
Inlining the worker meant it was not subject to minification. The hook name parser worker can be minified down to 839kB (from ≈1.6MB) and file fetcher to 218kB (from ≈400kB). This allows us to not create an async chunk for the worker loader. It's just 2kB that avoids a waterfall from loading the module and then loading the worker. Now we load the worker directly.
I only did this for the extensions since we have full control of the public path and where assets are placed. Can't guarantee the same for the other bundles especially because testing those is non-trivial.
Test plan
Hook name parsing works in https://rf3fky.csb.app/ for Edge, Chrome and Firefox