[DevTools] Handle LegacyHidden Fibers like Offscreen Fibers. #34564
+45
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Sep 23, 2025
| const commitData = store.profilerStore.getDataForRoot(rootID).commitData; | ||
| expect(commitData).toHaveLength(2); | ||
|
|
||
| const isLegacySuspense = React.version.startsWith('17'); |
There was a problem hiding this comment.
17 isn't what we refer to in the Fiber renderer as "legacy Suspense". Legacy Suspense had a Fragment for the content Fiber. 17 is using LegacyHiddenComponent and 18+ is using OffscreenComponent.
eps1lon
force-pushed
the
sebbie/09-23-_devtools_handle_legacyhidden_fibers_like_offscreen_fibers
branch
from
f493a42 to
f7e2e5f
Compare
eps1lon
commented
Sep 23, 2025
eps1lon
force-pushed
the
sebbie/09-23-_devtools_handle_legacyhidden_fibers_like_offscreen_fibers
branch
2 times, most recently
from
8dd516c to
daa9aee
Compare
This is mostly for React 17 which uses `LegacyHiddenComponent` instead of `Offscreen` for the content Fiber.
eps1lon
force-pushed
the
sebbie/09-23-_devtools_handle_legacyhidden_fibers_like_offscreen_fibers
branch
from
daa9aee to
8cd796b
Compare
hoxyq
approved these changes
Sep 23, 2025
eps1lon
deleted the
sebbie/09-23-_devtools_handle_legacyhidden_fibers_like_offscreen_fibers
branch
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for React 17 which uses
LegacyHiddenComponentinstead ofOffscreenfor the content Fiber. Though it's nice that support forenableLegacyHiddencomes with it.How did you test this change?