Skip to content

Conversation

poteto
Copy link
Member

@poteto poteto commented Oct 7, 2025

This has been incredibly frustrating as ESLint's own docs are clearly wrong (see #34679).

This PR uses eslint-plugin-react's setup as a reference, where the presets are assigned to configs.flat (not documented by eslint).

This has been incredibly frustrating as [ESLint's own docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs) are clearly wrong (see #34679).

This PR uses [eslint-plugin-react's setup](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/index.js) as a reference, where the presets are assigned  to `configs.flat` (not documented by eslint).
@meta-cla meta-cla bot added the CLA Signed label Oct 7, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 7, 2025
@react-sizebot
Copy link

Comparing: 3025aa3...7c2cbb3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 604.98 kB 604.98 kB = 107.14 kB 107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.95 kB 663.95 kB = 117.03 kB 117.03 kB
facebook-www/ReactDOM-prod.classic.js = 687.81 kB 687.81 kB = 121.07 kB 121.07 kB
facebook-www/ReactDOM-prod.modern.js = 678.24 kB 678.24 kB = 119.42 kB 119.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7c2cbb3

Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been such a pain, thank you for debugging.

@poteto poteto requested a review from mofeiZ October 7, 2025 20:18
@poteto poteto merged commit 848e0e3 into main Oct 7, 2025
247 checks passed
@poteto poteto deleted the pr34762 branch October 7, 2025 20:24
github-actions bot pushed a commit that referenced this pull request Oct 7, 2025
…4762)

This has been incredibly frustrating as [ESLint's own
docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs)
are clearly wrong (see #34679).

This PR uses [eslint-plugin-react's
setup](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/index.js)
as a reference, where the presets are assigned to `configs.flat` (not
documented by eslint).

DiffTrain build for [848e0e3](848e0e3)
github-actions bot pushed a commit that referenced this pull request Oct 7, 2025
…4762)

This has been incredibly frustrating as [ESLint's own
docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs)
are clearly wrong (see #34679).

This PR uses [eslint-plugin-react's
setup](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/index.js)
as a reference, where the presets are assigned to `configs.flat` (not
documented by eslint).

DiffTrain build for [848e0e3](848e0e3)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Oct 12, 2025
…cebook#34762)

This has been incredibly frustrating as [ESLint's own
docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs)
are clearly wrong (see facebook#34679).

This PR uses [eslint-plugin-react's
setup](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/index.js)
as a reference, where the presets are assigned to `configs.flat` (not
documented by eslint).

DiffTrain build for [848e0e3](facebook@848e0e3)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Oct 12, 2025
…cebook#34762)

This has been incredibly frustrating as [ESLint's own
docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs)
are clearly wrong (see facebook#34679).

This PR uses [eslint-plugin-react's
setup](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/index.js)
as a reference, where the presets are assigned to `configs.flat` (not
documented by eslint).

DiffTrain build for [848e0e3](facebook@848e0e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants