Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addons-animation.md #10144

Closed
wants to merge 1 commit into from
Closed

Update addons-animation.md #10144

wants to merge 1 commit into from

Conversation

tai2
Copy link

@tai2 tai2 commented Jul 11, 2017

Add a link to new documentation.

Add new a link to new documentation.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jul 11, 2017

IMO this is a bit confusing because our page is only for people who are looking for old docs.

@tai2
Copy link
Author

tai2 commented Jul 11, 2017

Searching for react animation methods by some keywords like "react animation", the old doc is still listed on top. This can lead people to misunderstand ReactTransitionGroup's latest function. At least, I misunderstood it.

For example, someone might convince himself that ReactTransitionGroup cannot use native animation event. It's false, of cause.

Adding the link will prevent readers to have wrong impression.

@tai2
Copy link
Author

tai2 commented Jul 11, 2017

I also think my writing may be confusing because I'm not a native speaker.
I will appreciate it if you correct it appropriately.

My hope is that people can easily reach the current official documentation.

@facebook facebook deleted a comment from stvkoch Jul 11, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Thank you for filing this PR!

I'm sorry to be the bearer of bad news, but the documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)

Would you be willing to re-open this PR on the new repo? I promise we'll review it quickly!

@bvaughn bvaughn closed this Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants