Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix - SetState callback called before component state is updated in ReactShallowRenderer #11507

Merged
merged 17 commits into from
Nov 22, 2017
Merged

Bug fix - SetState callback called before component state is updated in ReactShallowRenderer #11507

merged 17 commits into from
Nov 22, 2017

Commits on Nov 9, 2017

  1. Create test to verify ReactShallowRenderer bug (facebook#11496)

    @accordeiro
    accordeiro committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    035eb3d View commit details
    Browse the repository at this point in the history

  2. Fix ReactShallowRenderer callback bug on componentWillMount (facebook… 

    …#11496)
    @accordeiro
    accordeiro committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    856cb2b View commit details
    Browse the repository at this point in the history

  3. Improve fnction naming and clean up queued callback before call

    @accordeiro
    accordeiro committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    a269747 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into shallow-renderer-bug

    @accordeiro
    accordeiro committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    a13a3d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2017

  1. Run prettier on ReactShallowRenderer.js

    @accordeiro
    accordeiro committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    11b931d View commit details
    Browse the repository at this point in the history

  2. Consolidate callback call on ReactShallowRenderer.js

    @accordeiro
    accordeiro committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    ae88abd View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2017

  1. Ensure callback behavior is similar between ReactDOM and ReactShallow… 

    …Renderer
    @accordeiro
    accordeiro committed Nov 13, 2017
    Configuration menu
    Copy the full SHA
    87bf19f View commit details
    Browse the repository at this point in the history

  2. Fix Code Review requests (facebook#11507)

    @accordeiro
    accordeiro committed Nov 13, 2017
    Configuration menu
    Copy the full SHA
    120b399 View commit details
    Browse the repository at this point in the history

  3. Move test to ReactCompositeComponent

    @gaearon
    gaearon committed Nov 13, 2017
    Configuration menu
    Copy the full SHA
    cfa6552 View commit details
    Browse the repository at this point in the history

  4. Verify the callback gets called

    @gaearon
    gaearon committed Nov 13, 2017
    Configuration menu
    Copy the full SHA
    ffa5565 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2017

  1. Ensure multiple callbacks are correctly handled on ReactShallowRenderer

    @accordeiro
    accordeiro committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f242683 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'shallow-renderer-bug' of github.com:accordeiro/react in… 

    …to shallow-renderer-bug
    @accordeiro
    accordeiro committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    de20f22 View commit details
    Browse the repository at this point in the history

  3. Ensure the setState callback is called inside componentWillMount (Rea… 

    …ctDOM)
    @accordeiro
    accordeiro committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    194ff74 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Clear ReactShallowRenderer callback queue before actually calling the… 

    … callbacks
    @accordeiro
    accordeiro committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    2141b8c View commit details
    Browse the repository at this point in the history

  2. Add test for multiple callbacks on ReactShallowRenderer

    @accordeiro
    accordeiro committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    b3b0788 View commit details
    Browse the repository at this point in the history

  3. Ensure the ReactShallowRenderer callback queue is cleared after invok… 

    …ing callbacks
    @accordeiro
    accordeiro committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    0a58682 View commit details
    Browse the repository at this point in the history

  4. Remove references to internal fields on ReactShallowRenderer test

    @accordeiro
    accordeiro committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    ba0e995 View commit details
    Browse the repository at this point in the history