New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event plugins to addons #1170

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
@petehunt
Contributor

petehunt commented Feb 24, 2014

I did this in the most API-constrained way possible. Will write docs.

@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Feb 26, 2014

Member

Aw, we lost ABC order

Member

zpao commented Feb 26, 2014

Aw, we lost ABC order

@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Apr 18, 2014

Member

Anything else need to be done here @petehunt?

Member

zpao commented Apr 18, 2014

Anything else need to be done here @petehunt?

@ryanseddon

This comment has been minimized.

Show comment
Hide comment
@ryanseddon

ryanseddon May 29, 2014

Contributor

Just did a custom build with these changes and setup a demo but the onTouchTap event doesn't trigger in iOS but it does on desktop Chrome?

Contributor

ryanseddon commented May 29, 2014

Just did a custom build with these changes and setup a demo but the onTouchTap event doesn't trigger in iOS but it does on desktop Chrome?

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits May 29, 2014

Member

Try adding React.initializeTouchEvents(true) before any of your app code, if you don't have it already.

Member

sophiebits commented May 29, 2014

Try adding React.initializeTouchEvents(true) before any of your app code, if you don't have it already.

@ryanseddon

This comment has been minimized.

Show comment
Hide comment
@ryanseddon

ryanseddon May 29, 2014

Contributor

No that doesn't seem to work either, see updated test case.

Contributor

ryanseddon commented May 29, 2014

No that doesn't seem to work either, see updated test case.

@tmcw

This comment has been minimized.

Show comment
Hide comment
@tmcw

tmcw Jun 21, 2014

Contributor

The updated test case works for me in Mobile Safari on an iPhone 5S & in an emulator.

Contributor

tmcw commented Jun 21, 2014

The updated test case works for me in Mobile Safari on an iPhone 5S & in an emulator.

@jbrantly

This comment has been minimized.

Show comment
Hide comment
@jbrantly

jbrantly Jul 7, 2014

Contributor

👍 I would love to see this merged

Contributor

jbrantly commented Jul 7, 2014

👍 I would love to see this merged

@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Aug 13, 2014

Member

Nah. Let's hold off because supporting this is going to suck. We should figure something out for 1.0, so we can come back around to it then.

Member

zpao commented Aug 13, 2014

Nah. Let's hold off because supporting this is going to suck. We should figure something out for 1.0, so we can come back around to it then.

@slorber

This comment has been minimized.

Show comment
Hide comment
@slorber

slorber Jul 17, 2015

Contributor

+1

Contributor

slorber commented Jul 17, 2015

+1

@micky2be

This comment has been minimized.

Show comment
Hide comment
@micky2be

micky2be commented Jul 29, 2015

+1

@dzannotti

This comment has been minimized.

Show comment
Hide comment
@dzannotti

dzannotti commented Aug 19, 2015

+1

@sathify

This comment has been minimized.

Show comment
Hide comment
@sathify

sathify commented Aug 24, 2015

+1

@alancmclean

This comment has been minimized.

Show comment
Hide comment
@alancmclean

alancmclean commented Sep 3, 2015

+1

@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Sep 3, 2015

Member

Please don't add any more "+1" comments. If you don't have anything constructive, don't comment at all.

Member

zpao commented Sep 3, 2015

Please don't add any more "+1" comments. If you don't have anything constructive, don't comment at all.

@mhart

This comment has been minimized.

Show comment
Hide comment
@mhart

mhart Sep 3, 2015

@zpao is there a discussion happening around this somewhere? Your last comment was:

We should figure something out for 1.0, so we can come back around to it then.

mhart commented Sep 3, 2015

@zpao is there a discussion happening around this somewhere? Your last comment was:

We should figure something out for 1.0, so we can come back around to it then.

@zpao

This comment has been minimized.

Show comment
Hide comment
@zpao

zpao Sep 3, 2015

Member

No, not that I know of.

Member

zpao commented Sep 3, 2015

No, not that I know of.

@mhart

This comment has been minimized.

Show comment
Hide comment
@mhart

mhart Sep 3, 2015

So what's the status of it do you think?

mhart commented Sep 3, 2015

So what's the status of it do you think?

@mhart

This comment has been minimized.

Show comment
Hide comment
@mhart

mhart Sep 3, 2015

@zpao So this issue, along with #436 are both referenced from https://github.com/zilverline/react-tap-event-plugin – where it says "When Facebook solves #436 and #1170, this repo will disappear". And http://react-components.com/component/material-ui#react-tap-event-plugin where it says "This dependency is temporary and will go away once react v1.0 is released"

I believe that's why there's still interest in this issue/PR – really I think everyone's just interested in what the story is for tap events for React.

So is there anywhere better to follow the status of this in React, or is this PR (or #436) the best place?

mhart commented Sep 3, 2015

@zpao So this issue, along with #436 are both referenced from https://github.com/zilverline/react-tap-event-plugin – where it says "When Facebook solves #436 and #1170, this repo will disappear". And http://react-components.com/component/material-ui#react-tap-event-plugin where it says "This dependency is temporary and will go away once react v1.0 is released"

I believe that's why there's still interest in this issue/PR – really I think everyone's just interested in what the story is for tap events for React.

So is there anywhere better to follow the status of this in React, or is this PR (or #436) the best place?

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Sep 3, 2015

Member

Let's go with #436.

Member

sophiebits commented Sep 3, 2015

Let's go with #436.

@mhart

This comment has been minimized.

Show comment
Hide comment
@mhart

mhart Sep 3, 2015

Cool, thanks @spicyj !

mhart commented Sep 3, 2015

Cool, thanks @spicyj !

@c0b41

This comment has been minimized.

Show comment
Hide comment
@c0b41

c0b41 commented Oct 20, 2015

+1

@anaibol

This comment has been minimized.

Show comment
Hide comment
@anaibol

anaibol commented Feb 25, 2016

+1

@facebook facebook locked and limited conversation to collaborators Feb 25, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.