Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around IE/Edge bug when rendering inputs in separate windows via portals #11870

Merged
merged 4 commits into from
Jan 5, 2018
Merged

Work around IE/Edge bug when rendering inputs in separate windows via portals #11870

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
120d6c4
seperated enumerable to another object.defineProperty for ie11
Dec 16, 2017
c7d6bea
comment added
Dec 17, 2017
4a8786d
Merge branch 'master' into issue11768
Dec 25, 2017
56d613d
Reword the explanation
gaearon Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-dom/src/client/inputValueTracking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ function trackValueOnNode(node: any): ?ValueTracker {
}

Object.defineProperty(node, valueField, {
enumerable: descriptor.enumerable,
configurable: true,
get: function() {
return descriptor.get.call(this);
Expand All @@ -80,6 +79,13 @@ function trackValueOnNode(node: any): ?ValueTracker {
descriptor.set.call(this, value);
},
});
// We could've passed this the first time
// but it triggers a bug in IE11 and Edge 14/15.
// Calling defineProperty() again should be equivalent.
// https://github.com/facebook/react/issues/11768
Object.defineProperty(node, valueField, {
enumerable: descriptor.enumerable,
});

const tracker = {
getValue() {
Expand Down