Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DEV performance regression by avoiding Object.assign on Fibers #12510

Merged
merged 2 commits into from
Apr 1, 2018
Merged

Fix DEV performance regression by avoiding Object.assign on Fibers #12510

merged 2 commits into from
Apr 1, 2018

Commits on Apr 1, 2018

  1. Fix DEV performance regression by avoiding Object.assign on Fibers

    @gaearon
    gaearon committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    5036a6c View commit details
    Browse the repository at this point in the history

  2. Reduce allocations in hot path by reusing the stash 

    Since performUnitOfWork() is not reentrant, it should be safe to reuse the same stash every time instead of creating a new object.
    @gaearon
    gaearon committed Apr 1, 2018
    Configuration menu
    Copy the full SHA
    de91f01 View commit details
    Browse the repository at this point in the history