Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw more specific error if passed undefined in React.cloneElement #12534

Merged
merged 14 commits into from
Apr 10, 2018
Merged

Throw more specific error if passed undefined in React.cloneElement #12534

Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7bc5fd5
throw error if passed undefined
Apr 4, 2018
8ee2452
should be TypeError
Apr 4, 2018
33d1edf
simplify
Apr 5, 2018
48c7b53
use invariant
Apr 5, 2018
34816fc
editor messed up spacing
Apr 5, 2018
2733707
better check
Apr 6, 2018
44df599
Revert "better check"
Apr 6, 2018
7f6d18b
Merge branch 'master' into clone-element-throw-error-on-undefined
Apr 6, 2018
baa4d84
yarn prettier test was failing
Apr 6, 2018
80de944
more explicit copy
Apr 6, 2018
e3416ee
es6 import
Apr 6, 2018
905abfc
tests
Apr 10, 2018
d20de72
formatting
Apr 10, 2018
070ef20
Move import
gaearon Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react/src/ReactElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import ReactCurrentOwner from './ReactCurrentOwner';

const hasOwnProperty = Object.prototype.hasOwnProperty;

const invariant = require('fbjs/lib/invariant');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you could use ES6 imports instead since the former ones do?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!


const RESERVED_PROPS = {
key: true,
ref: true,
Expand Down Expand Up @@ -290,6 +292,11 @@ export function cloneAndReplaceKey(oldElement, newKey) {
* See https://reactjs.org/docs/react-api.html#cloneelement
*/
export function cloneElement(element, config, children) {
invariant(
!(element === null || element === undefined),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just use a loose equality check here

element != null

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right yes, because the type conversion will catch undefined 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we've intentionally stopped using loose checks a while ago because they sometimes cause engine deoptimizations. I'd prefer strict ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon didn't know that. We still have tons of places where we use loose equality checks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon okay gotcha, reverted that.

@aweary I can look into switching some over in a PR maybe? That should be pretty straightforward and I would love the opportunity to get more familiar with the codebase.

Copy link
Contributor

@aweary aweary Apr 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevy I don't know, I'm not sure it's worth it? It could be helpful to make the changes and then somehow benchmark them. I'd also be interested in seeing a profile that shows the current deoptimizations and their impact as well. Making all the checks strict would increase the overall bundle size, so there are other costs to consider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aweary hmmm okay, I’ll wait until a decision is made before I start on that then.

'Cannot clone a null or undefined element.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like React.cloneElement(...): The argument must be a React element, but you passed %s. and either null or undefined as second argument (invariant will interpolate it).

Copy link
Contributor Author

@wherestheguac wherestheguac Apr 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks that’s cool, I’m going to read up on how invariant works for the future for sure. I’m also going to look at writing some tests.

Also wanted to ask if you have any input on this thread: #12534 (review)

);

let propName;

// Original props are copied
Expand Down