-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix “no onChange handler” warning to fire on falsy values ("", 0, false) too #12628
Merged
gaearon
merged 21 commits into
facebook:master
from
wherestheguac:falsy-proptypes-no-warning-bug
Jul 17, 2018
Merged
Fix “no onChange handler” warning to fire on falsy values ("", 0, false) too #12628
gaearon
merged 21 commits into
facebook:master
from
wherestheguac:falsy-proptypes-no-warning-bug
Jul 17, 2018
+128
−36
Commits on Apr 17, 2018
-
throw warning for falsey
value
propNicole Levy committedApr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 49851ff - Browse repository at this point
Copy the full SHA 49851ffView commit details -
add nop onChange handler to tests for
value
propNicole Levy committedApr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 32547ff - Browse repository at this point
Copy the full SHA 32547ffView commit details -
Nicole Levy committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 9e0be3d - Browse repository at this point
Copy the full SHA 9e0be3dView commit details -
Nicole Levy committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 15302d6 - Browse repository at this point
Copy the full SHA 15302d6View commit details -
Nicole Levy committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for d8fbf04 - Browse repository at this point
Copy the full SHA d8fbf04View commit details -
Nicole Levy committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for d4a0e3c - Browse repository at this point
Copy the full SHA d4a0e3cView commit details -
Nicole Levy committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for f2fcf3c - Browse repository at this point
Copy the full SHA f2fcf3cView commit details -
Nicole Levy committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for 41f4311 - Browse repository at this point
Copy the full SHA 41f4311View commit details -
Nicole Levy committed
Apr 17, 2018 Configuration menu - View commit details
-
Copy full SHA for b17fab1 - Browse repository at this point
Copy the full SHA b17fab1View commit details
Commits on May 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b91c2b0 - Browse repository at this point
Copy the full SHA b91c2b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 484b0cb - Browse repository at this point
Copy the full SHA 484b0cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e68c16a - Browse repository at this point
Copy the full SHA e68c16aView commit details
Commits on Jun 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3804ecd - Browse repository at this point
Copy the full SHA 3804ecdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70235ae - Browse repository at this point
Copy the full SHA 70235aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08bab46 - Browse repository at this point
Copy the full SHA 08bab46View commit details
Commits on Jul 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c802ca5 - Browse repository at this point
Copy the full SHA c802ca5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a03a7a - Browse repository at this point
Copy the full SHA 6a03a7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 731e3e0 - Browse repository at this point
Copy the full SHA 731e3e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bf0648 - Browse repository at this point
Copy the full SHA 8bf0648View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e2d2a3 - Browse repository at this point
Copy the full SHA 1e2d2a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cfbed6 - Browse repository at this point
Copy the full SHA 9cfbed6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.