Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix “no onChange handler” warning to fire on falsy values ("", 0, false) too #12628

Merged
merged 21 commits into from
Jul 17, 2018
Merged

Fix “no onChange handler” warning to fire on falsy values ("", 0, false) too #12628

merged 21 commits into from
Jul 17, 2018
+128 −36

Commits on Apr 17, 2018

  1. throw warning for falsey value prop

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    49851ff View commit details
    Browse the repository at this point in the history

  2. add nop onChange handler to tests for value prop

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    32547ff View commit details
    Browse the repository at this point in the history

  3. prettier

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    9e0be3d View commit details
    Browse the repository at this point in the history

  4. check for falsey checked

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    15302d6 View commit details
    Browse the repository at this point in the history

  5. fix tests for checked prop

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    d8fbf04 View commit details
    Browse the repository at this point in the history

  6. new tests for value prop

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    d4a0e3c View commit details
    Browse the repository at this point in the history

  7. test formatting

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    f2fcf3c View commit details
    Browse the repository at this point in the history

  8. forgot 0 (:

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    41f4311 View commit details
    Browse the repository at this point in the history

  9. test for falsey checked prop

    Nicole Levy committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    b17fab1 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2018

  1. add null check

    @wherestheguac
    wherestheguac committed May 16, 2018
    Configuration menu
    Copy the full SHA
    b91c2b0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into falsy-proptypes-no-warning-bug

    @wherestheguac
    wherestheguac committed May 16, 2018
    Configuration menu
    Copy the full SHA
    484b0cb View commit details
    Browse the repository at this point in the history

  3. Update ReactDOMInput-test.js

    @gaearon
    gaearon authored May 16, 2018
    Configuration menu
    Copy the full SHA
    e68c16a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2018

  1. revert unneeded change

    @wherestheguac
    wherestheguac committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    3804ecd View commit details
    Browse the repository at this point in the history

  2. prettier

    @wherestheguac
    wherestheguac committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    70235ae View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into falsy-proptypes-no-warning-bug

    @wherestheguac
    wherestheguac committed Jun 3, 2018
    Configuration menu
    Copy the full SHA
    08bab46 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2018

  1. Merge branch 'master' into falsy-proptypes-no-warning-bug

    @gaearon
    gaearon authored Jul 17, 2018
    Configuration menu
    Copy the full SHA
    c802ca5 View commit details
    Browse the repository at this point in the history

  2. Update DOMPropertyOperations-test.js

    @gaearon
    gaearon authored Jul 17, 2018
    Configuration menu
    Copy the full SHA
    6a03a7a View commit details
    Browse the repository at this point in the history

  3. Update ReactDOMInput-test.js

    @gaearon
    gaearon authored Jul 17, 2018
    Configuration menu
    Copy the full SHA
    731e3e0 View commit details
    Browse the repository at this point in the history

  4. Update ReactDOMSelect-test.js

    @gaearon
    gaearon authored Jul 17, 2018
    Configuration menu
    Copy the full SHA
    8bf0648 View commit details
    Browse the repository at this point in the history

  5. Fixes and tests

    @gaearon
    gaearon committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    1e2d2a3 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary changes

    @gaearon
    gaearon committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    9cfbed6 View commit details
    Browse the repository at this point in the history