Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSR crash on a hasOwnProperty attribute #13303

Merged
merged 1 commit into from Aug 1, 2018

Conversation

@gaearon
Copy link
Member

gaearon commented Aug 1, 2018

While fixing #13302 we found an issue that can cause an SSR crash if the user has control over an attribute name.

While this situation is likely very uncommon, we've included a fix for this crash in react-dom@16.4.2 that went out today.

We did not backport this fix to other minor releases because it's only a crash.

@gaearon gaearon merged commit f60a7f7 into facebook:master Aug 1, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@gaearon gaearon deleted the gaearon:fix-error-hasown branch Aug 1, 2018
segoddnja added a commit to segoddnja/react that referenced this pull request Aug 1, 2018
TejasQ added a commit to TejasQ/react that referenced this pull request Aug 26, 2018
iyegoroff added a commit to iyegoroff/react that referenced this pull request Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.