Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSR crash on a hasOwnProperty attribute #13303

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 1, 2018

While fixing #13302 we found an issue that can cause an SSR crash if the user has control over an attribute name.

While this situation is likely very uncommon, we've included a fix for this crash in react-dom@16.4.2 that went out today.

We did not backport this fix to other minor releases because it's only a crash.

@gaearon gaearon merged commit f60a7f7 into facebook:master Aug 1, 2018
@gaearon gaearon deleted the fix-error-hasown branch August 1, 2018 20:52
segoddnja pushed a commit to segoddnja/react that referenced this pull request Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants