Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "tracking" API to "tracing" #13641

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 13, 2018

Changes

Verification and testing

  • Manually reviewed commit 69659e6 to catch false positives
  • Manually reviewed the built bundles to check for any obvious errors
  • Lint and Flow
  • yarn test and yarn test-build
  • Tested tracing and packaging fixtures against new built bundle
  • Tested the "suspense" fixture and DevTools profiler against the built bundle

Follow up work

@sizebot
Copy link

sizebot commented Sep 13, 2018

Details of bundled changes.

Comparing: ecbf7af...69659e6

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD
schedule-tracking.development.js +3.6% +6.8% 10.27 KB 10.64 KB 2.35 KB 2.51 KB NODE_DEV
ScheduleTracking-dev.js -0.7% -1.0% 10.36 KB 10.29 KB 2.28 KB 2.25 KB FB_WWW_DEV
schedule-tracing.development.js n/a n/a 0 B 10.25 KB 0 B 2.35 KB NODE_DEV
schedule-tracing.production.min.js n/a n/a 0 B 718 B 0 B 373 B NODE_PROD
schedule-tracing.profiling.min.js n/a n/a 0 B 3.25 KB 0 B 990 B NODE_PROFILING
ScheduleTracing-dev.js n/a n/a 0 B 10.34 KB 0 B 2.27 KB FB_WWW_DEV
ScheduleTracing-prod.js n/a n/a 0 B 899 B 0 B 425 B FB_WWW_PROD
ScheduleTracing-profiling.js n/a n/a 0 B 6.82 KB 0 B 1.23 KB FB_WWW_PROFILING

Generated by 🚫 dangerJS

@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 13, 2018

Oh hi @sizebot 👋

@bvaughn bvaughn merged commit 4bcee56 into facebook:master Sep 13, 2018
@bvaughn bvaughn deleted the stop-tracking-things branch September 13, 2018 21:23
@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 18, 2018

Gists have been updated as of the 16.5.2/0.5.0 release

@gaearon
Copy link
Collaborator

gaearon commented Sep 19, 2018

Gists have been updated as of the 16.5.2/0.5.0 release

I hate to break the news but: #13683

@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 19, 2018

😭 lol

@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 19, 2018

Well whenever we cut the next release, whoever cuts it, will need to make sure the blog post on reactjs.org is updated and just ping me about the gists 😄

@chrisnojima
Copy link

@bvaughn does this break compatibility with React Native 0.57.0?

https://github.com/facebook/react-native/blob/master/Libraries/Renderer/oss/ReactNativeRenderer-dev.js#L29

error: bundling failed: Error: Unable to resolve module `schedule/tracking` from `/Users/chrisnojima/go/src/github.com/keybase/client/shared/node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js`: Module `schedule/tracking` does not exist in the Haste module map

rolling back to 16.5.1 fixes this for me locally

@chrisnojima chrisnojima mentioned this pull request Sep 19, 2018
3 tasks
@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 19, 2018

Hm, I would not expect it to because react-native depends on react@16.5.0 which itself depends on schedule@^0.3.0 which has "tracking". (This change wasn't made until schedule@0.5.0 which will not match the semver range "^0.3.0")

@chrisnojima
Copy link

I see. My project is web + RN with a shared package.json and we usually keep up to date with react and don't stay on the exact one RN wants, this is usually ok but I guess this is a breaking change for us. tnx

@gaearon
Copy link
Collaborator

gaearon commented Sep 19, 2018

we usually keep up to date with react and don't stay on the exact one RN wants

This is not supported and can always break indeed.

Simek pushed a commit to Simek/react that referenced this pull request Oct 25, 2018
* Replaced "tracking" with "tracing" in all directory and file names
* Global rename of track/tracking/tracked to trace/tracing/traced
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
* Replaced "tracking" with "tracing" in all directory and file names
* Global rename of track/tracking/tracked to trace/tracing/traced
@agm1984
Copy link

agm1984 commented Apr 8, 2019

I just encountered some issues here while upgrading from RN 0.56 to 0.57, I carelessly upgraded the versions in package.json for react, react-native, and metro-react-native-babel-preset.

Everything worked except I was getting a horrific error message about the scheduler in the haste map. It lead to a couple red herring issues.

Be careful if you are upgrading from 0.56 to 0.57. If you get weirdness, simply follow the diffs here (https://github.com/react-native-community/rn-diff-purge) and look at all the 0.57.X ones and definitely note how the metro package goes up to 0.49 and back down to 0.48.5. That may be key to that scheduler error.

After double-checking all the diffs between 0.56 up to and excluding 0.58, my project is building both Android and iOS successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants