Enable hooks in www build #14116
Merged
Enable hooks in www build #14116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `enableHooks` feature flag used to only control whether the API was exposed on the React package. But now it also determines if the dispatcher and implementation are included in the bundle. We're using hooks in www, so I've switched the feature flag to `true` in the www build. (Alternatively, we could have two feature flags: one for the implementation and dispatcher, and one for exposing the API on the React package.)
gaearon
approved these changes
Nov 6, 2018
Details of bundled changes.Comparing: e9a2ec9...da45ed0 react
react-dom
react-art
scheduler
Generated by 🚫 dangerJS |
gaearon
pushed a commit
to gaearon/react
that referenced
this pull request
Nov 6, 2018
The `enableHooks` feature flag used to only control whether the API was exposed on the React package. But now it also determines if the dispatcher and implementation are included in the bundle. We're using hooks in www, so I've switched the feature flag to `true` in the www build. (Alternatively, we could have two feature flags: one for the implementation and dispatcher, and one for exposing the API on the React package.)
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
The `enableHooks` feature flag used to only control whether the API was exposed on the React package. But now it also determines if the dispatcher and implementation are included in the bundle. We're using hooks in www, so I've switched the feature flag to `true` in the www build. (Alternatively, we could have two feature flags: one for the implementation and dispatcher, and one for exposing the API on the React package.)
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
The `enableHooks` feature flag used to only control whether the API was exposed on the React package. But now it also determines if the dispatcher and implementation are included in the bundle. We're using hooks in www, so I've switched the feature flag to `true` in the www build. (Alternatively, we could have two feature flags: one for the implementation and dispatcher, and one for exposing the API on the React package.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enableHooksfeature flag used to only control whether the API was exposed on the React package. But since #14111 landed, it also determines if the dispatcher and implementation are included in the bundle.We're using hooks in www, so I've switched the feature flag to
truein the www build.(Alternatively, we could have two feature flags: one for the implementation and dispatcher, and one for exposing the API on the React package.)