fix typo & DCE #14124
fix typo & DCE #14124
Conversation
| @@ -56,7 +56,7 @@ function escapeHtml(string) { | |||
|
|
|||
| let escape; | |||
| let html = ''; | |||
| let index = 0; | |||
There was a problem hiding this comment.
Below we do index = match.index, so it doesn't need assign here
| @@ -14,7 +14,7 @@ const { | |||
| __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, | |||
| } = require('ReactNative'); | |||
|
|
|||
| import type {NativeMethodsMixinType} from 'ReactNativeTypes'; | |||
There was a problem hiding this comment.
These (and below) are wrong because they're written to be copied into RN repo.
There was a problem hiding this comment.
Oh, don't know that, could we add some comments about that, I think that would be better?
There was a problem hiding this comment.
Done. Remove these and below
| @@ -881,7 +881,6 @@ function unmountHostComponents(current): void { | |||
| } | |||
| parent = parent.return; | |||
| } | |||
| currentParentIsValid = true; | |||
There was a problem hiding this comment.
Every switch case we do break, so this line is unreachable
There was a problem hiding this comment.
This looks reachable to me. The break takes us to exactly this line.
There was a problem hiding this comment.
Oops, sorry, I confuse the brace.
Details of bundled changes.Comparing: bd5a6d3...cac6224 scheduler
Generated by 🚫 dangerJS |
NE-SmallTown
force-pushed
the
fix-whatever
branch
from
edec7db
to
6aca7ca
Compare
NE-SmallTown
force-pushed
the
fix-whatever
branch
from
6aca7ca
to
cac6224
Compare
No description provided.