Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errant return assignment #14164

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Nov 9, 2018

Oopsie!

This could have been avoided if our types were modeled correctly with Flow (using a disjoint union).

Fuzz tester didn't catch it because it does not generate cases where a Suspense component mounts with no children. I'll update it.

Fixes #14162

Oopsie!

This could have been avoided if our types were modeled correctly with
Flow (using a disjoint union).

Fuzz tester didn't catch it because it does not generate cases where
a Suspense component mounts with no children. I'll update it.
@acdlite acdlite force-pushed the remove-errant-return-assignment branch from da0641c to 355c0be Compare November 9, 2018 01:26
@sizebot
Copy link

sizebot commented Nov 9, 2018

Details of bundled changes.

Comparing: 7fd1661...355c0be

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you not need to update the return pointer on currentPrimaryChild and its siblings (when they exist)?

@acdlite
Copy link
Collaborator Author

acdlite commented Nov 9, 2018

@sophiebits You do right before you traverse down into them, which is not true in this case. I think this is some copypasta from a different branch.

@acdlite acdlite merged commit 4b163fe into facebook:master Nov 9, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Oopsie!

This could have been avoided if our types were modeled correctly with
Flow (using a disjoint union).

Fuzz tester didn't catch it because it does not generate cases where
a Suspense component mounts with no children. I'll update it.
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
Oopsie!

This could have been avoided if our types were modeled correctly with
Flow (using a disjoint union).

Fuzz tester didn't catch it because it does not generate cases where
a Suspense component mounts with no children. I'll update it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants