New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for mixing react-dom/server@16.6 and react@<16.6 #14291

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@gaearon
Copy link
Member

gaearon commented Nov 20, 2018

This prevents an obscure issue if you use react-dom/server from 16.6 but react from 16.5 or earlier. We decided to support this a while ago and it's easy to keep working.

I didn't bother writing a test because I'm lazy.

@gaearon gaearon merged commit 327cf0e into facebook:master Nov 20, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@gaearon gaearon deleted the gaearon:ssr-166 branch Nov 20, 2018

@sebmarkbage

This comment has been minimized.

Copy link
Member

sebmarkbage commented Nov 20, 2018

Is this slower now? Please add a follow up task to make it faster again. Does it prevent inlining (by making the generated to code larger)? This was very intentional minimal code.

@sebmarkbage

This comment has been minimized.

Copy link
Member

sebmarkbage commented Nov 20, 2018

The idea here is that it should just do a hidden class check, then put the current value in the register and jump over it with the same label as it would use for the loop. Thereby making this code inline-friendly (in the VM).

This check would add additional logic that at least deals with the other case and might need more registers.

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Nov 20, 2018

Isn’t this DEV only?

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Nov 20, 2018

Doh. I misread the DEV closing brace. 😳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment