Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprename useImperativeMethods -> useImperativeHandle #14565
+32
−32
Conversation
facebook-github-bot
added
the
CLA Signed
label
Jan 10, 2019
threepointone
referenced this pull request
Jan 10, 2019
Merged
rename useImperativeMethods -> useImperativeHandle #1544
@@ -174,7 +174,7 @@ function useImperativeMethods<T>( | |||
instance = ref.current; | |||
} | |||
hookLog.push({ | |||
primitive: 'ImperativeMethods', | |||
primitive: 'ImperativeHandle', |
This comment has been minimized.
This comment has been minimized.
threepointone
merged commit b4ad8e9
into
facebook:master
Jan 10, 2019
1 check passed
ci/circleci
Your tests passed on CircleCI!
Details
added a commit
to threepointone/DefinitelyTyped
that referenced
this pull request
Jan 10, 2019
This comment has been minimized.
This comment has been minimized.
Thanks for the heads up Sunil. If only DevTools just "read" that Right now, I've had to fork that file into DevTools entirely. So I'll need to copy over this change too. |
bvaughn
referenced this pull request
Jan 14, 2019
Closed
Rename React hook useImperativeMethods -> useImperativeHandle #7352
threepointone
referenced this pull request
Jan 14, 2019
Merged
@types/react - rename useImperativeMethods -> useImperativeHandle #32144
added a commit
to facebook/flow
that referenced
this pull request
Jan 15, 2019
hamlim
referenced this pull request
Jan 21, 2019
Closed
useImperativeHandle should warn when second arg isn't a function #14629
added a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
added a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
added a commit
to yesmeck/react-with-hooks
that referenced
this pull request
Feb 3, 2019
added a commit
to Kiku-git/react
that referenced
this pull request
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
threepointone commentedJan 10, 2019
just a project-wide search/replace. I'll send changes for docs in a bit too.
I have done the builds, run the tests, linted and flow checked.