rename useImperativeMethods -> useImperativeHandle #14565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
Jan 10, 2019
| @@ -174,7 +174,7 @@ function useImperativeMethods<T>( | |||
| instance = ref.current; | |||
| } | |||
| hookLog.push({ | |||
| primitive: 'ImperativeMethods', | |||
| primitive: 'ImperativeHandle', | |||
There was a problem hiding this comment.
Heads up to @bvaughn in case DevTools reads this
threepointone
added a commit
to threepointone/DefinitelyTyped
that referenced
this pull request
Jan 10, 2019
*Do not merge this just yet*. We're in the process of renaming this function (in facebook/react#14565), so making a followup PR here for when we do land it. Thanks very much!
|
Thanks for the heads up Sunil. If only DevTools just "read" that 😅 Right now, I've had to fork that file into DevTools entirely. So I'll need to copy over this change too. |
9 tasks
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Jan 15, 2019
Summary: To stay in sync with the change made in facebook/react#14565 Disclaimer: These changes were manual and I'm going to let CI verify them. I'm having trouble actually building Flow locally and running tests. `make` fails with > hh_shared.c:1524:16: error: conflicting types for 'hh_collect' CAMLprim value hh_collect(void) { ^ > .../flow/_build/hack/heap/hh_shared.h:56:16: note: previous declaration is here CAMLprim value hh_collect(value aggressive_val); ^ hh_shared.c:2670:16: error: conflicting types for 'hh_save_dep_table_sqlite' CAMLprim value hh_save_dep_table_sqlite( ^ .../flow/_build/hack/heap/hh_shared.h:106:16: note: previous declaration is here CAMLprim value hh_save_dep_table_sqlite( Pull Request resolved: #7352 Reviewed By: bvaughn Differential Revision: D13653071 Pulled By: jbrown215 fbshipit-source-id: 9bcb185e62b6b01ecc05a07c57f6694c87b15229
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
yesmeck
added a commit
to yesmeck/react-with-hooks
that referenced
this pull request
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a project-wide search/replace. I'll send changes for docs in a bit too.
I have done the builds, run the tests, linted and flow checked.