/react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename useImperativeMethods -> useImperativeHandle #14565

Merged
merged 1 commit into from Jan 10, 2019
+32 −32

Conversation

Reviewers

@gaearon gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
4 participants
@threepointone @bvaughn @gaearon @facebook-github-bot
@threepointone
Copy link
Contributor

threepointone commented Jan 10, 2019

just a project-wide search/replace. I'll send changes for docs in a bit too.
I have done the builds, run the tests, linted and flow checked.

@facebook-github-bot facebook-github-bot added the CLA Signed label Jan 10, 2019

@threepointone threepointone referenced this pull request Jan 10, 2019

Merged

rename useImperativeMethods -> useImperativeHandle #1544

@gaearon

gaearon approved these changes Jan 10, 2019
View changes

Copy link
Member

gaearon left a comment

Seems legit.
packages/react-debug-tools/src/ReactDebugHooks.js
@@ -174,7 +174,7 @@ function useImperativeMethods<T>(
instance = ref.current;
}
hookLog.push({
primitive: 'ImperativeMethods',
primitive: 'ImperativeHandle',

This comment has been minimized.

Sign in to view
Copy link
@gaearon

gaearon Jan 10, 2019

Member

Heads up to @bvaughn in case DevTools reads this

@threepointone threepointone merged commit b4ad8e9 into facebook:master Jan 10, 2019
1 check passed

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

threepointone added a commit to threepointone/DefinitelyTyped that referenced this pull request Jan 10, 2019

@threepointone
react - rename useImperativeMethods -> useImperativeHandle 
*Do not merge this just yet*. We're in the process of renaming this function (in facebook/react#14565), so making a followup PR here for when we do land it. Thanks very much!
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
12f79a6
@bvaughn

This comment has been minimized.

Sign in to view
Copy link
Contributor

bvaughn commented Jan 10, 2019

Thanks for the heads up Sunil. If only DevTools just "read" that 😅

Right now, I've had to fork that file into DevTools entirely. So I'll need to copy over this change too.

@bvaughn bvaughn referenced this pull request Jan 14, 2019

Closed

Rename React hook useImperativeMethods -> useImperativeHandle #7352

@threepointone threepointone referenced this pull request Jan 14, 2019

Merged

@types/react - rename useImperativeMethods -> useImperativeHandle #32144

9 of 9 tasks complete

facebook-github-bot added a commit to facebook/flow that referenced this pull request Jan 15, 2019

@bvaughn @facebook-github-bot
[PR] Rename React hook useImperativeMethods -> useImperativeHandle 
Summary:
To stay in sync with the change made in facebook/react#14565

Disclaimer: These changes were manual and I'm going to let CI verify them. I'm having trouble actually building Flow locally and running tests. `make` fails with
> hh_shared.c:1524:16: error: conflicting types for 'hh_collect'
CAMLprim value hh_collect(void) {
                ^
> .../flow/_build/hack/heap/hh_shared.h:56:16: note: previous declaration is here
CAMLprim value hh_collect(value aggressive_val);
               ^
hh_shared.c:2670:16: error: conflicting types for 'hh_save_dep_table_sqlite'
CAMLprim value hh_save_dep_table_sqlite(
               ^
.../flow/_build/hack/heap/hh_shared.h:106:16: note: previous declaration is here
CAMLprim value hh_save_dep_table_sqlite(
Pull Request resolved: #7352

Reviewed By: bvaughn

Differential Revision: D13653071

Pulled By: jbrown215

fbshipit-source-id: 9bcb185e62b6b01ecc05a07c57f6694c87b15229
Loading status checks…
8849f49

@hamlim hamlim referenced this pull request Jan 21, 2019

Closed

useImperativeHandle should warn when second arg isn't a function #14629

jetoneza added a commit to jetoneza/react that referenced this pull request Jan 23, 2019

@threepointone @jetoneza
rename useImperativeMethods -> useImperativeHandle (facebook#14565)
fa8a6ec

n8schloss added a commit to n8schloss/react that referenced this pull request Jan 31, 2019

@threepointone @n8schloss
rename useImperativeMethods -> useImperativeHandle (facebook#14565)
1909628

yesmeck added a commit to yesmeck/react-with-hooks that referenced this pull request Feb 3, 2019

@yesmeck
Rename useImperativeMethods to useImperativeHandle. 
Follow up facebook/react#14565
Loading status checks…
143855f

Kiku-git added a commit to Kiku-git/react that referenced this pull request Feb 10, 2019

@threepointone @Kiku-git
rename useImperativeMethods -> useImperativeHandle (facebook#14565)
6a9d3cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment