New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 16.8.0 changelog and update some READMEs #14692

Closed
wants to merge 18 commits into
base: master
from

Conversation

Projects
None yet
@gaearon
Copy link
Member

gaearon commented Jan 24, 2019

NOTE BEFORE MERGE: set the release date.

gaearon added some commits Jan 24, 2019

@gaearon gaearon changed the title Add 16.8.0 changelog Add 16.8.0 changelog and update some READMEs Jan 24, 2019

@alexkrolick alexkrolick referenced this pull request Jan 24, 2019

Merged

Hooks Testing 🎣 #274

4 of 4 tasks complete

gaearon added some commits Jan 25, 2019

fix
@RobinMalfait

This comment has been minimized.

Copy link

RobinMalfait commented Jan 29, 2019

IT'S HAPPENING, 4th of February!

@GonchuB

This comment has been minimized.

Copy link

GonchuB commented Jan 29, 2019

🎣

@sami616

This comment has been minimized.

Copy link

sami616 commented Jan 29, 2019

YESSS! 💥

@jamuhl jamuhl referenced this pull request Jan 29, 2019

Closed

v10: hooks and suspense #591

7 of 7 tasks complete
@sebmarkbage
Copy link
Member

sebmarkbage left a comment

We should include the breaking API changes, that we haven't made yet, into the change log too.

@gaearon

This comment has been minimized.

Copy link
Member Author

gaearon commented Jan 29, 2019

I’ll add the useReducer one, is there more?

@Jessidhia

This comment has been minimized.

Copy link
Contributor

Jessidhia commented Jan 29, 2019

I'm curious about the fate of useCallback. It seemed to be the one most likely to change early on.

@gaearon

This comment has been minimized.

Copy link
Member Author

gaearon commented Jan 29, 2019

No changes planned to it for now.

On a side note — we appreciate the community excitement but it’s creating some noise across issues and PRs that makes it more challenging to get the work done and make sure we don’t forget anything. We’d appreciate a bit patience and restraint in posting until we flesh the details out and push the release. I put a date as an estimate but we’ve already moved it a few times, and won’t hesitate to move it again if we don’t feel the release is solid enough. It will be ready when it’s ready. Thanks.

Show resolved Hide resolved CHANGELOG.md Outdated
@RedNinjaX

This comment has been minimized.

Copy link

RedNinjaX commented Jan 29, 2019

So no kind of useErrorBoundary hook before release? Was looking forward to ridding of my last class component but this is none the less exciting news. Excellent job, I can't wait!

Update CHANGELOG.md
Co-Authored-By: gaearon <dan.abramov@gmail.com>
@gaearon

This comment has been minimized.

Copy link
Member Author

gaearon commented Jan 29, 2019

No, it wouldn’t be a good candidate for a Hook. This is about different example but maybe it helps: https://overreacted.io/why-isnt-x-a-hook/

@KentoMoriwaki KentoMoriwaki referenced this pull request Jan 30, 2019

Closed

Frontend Night #33 #34

@cullophid

This comment has been minimized.

Copy link

cullophid commented Jan 30, 2019

https://youtu.be/ckbhnKVRWUA

@mohsinulhaq

This comment has been minimized.

Copy link

mohsinulhaq commented Jan 30, 2019

I am so proud of this community 😊

@mbasso mbasso referenced this pull request Feb 1, 2019

Open

useWasm hook #3

@andrescalco

This comment has been minimized.

Copy link

andrescalco commented Feb 4, 2019

It's time!

@ppbl

This comment has been minimized.

Copy link

ppbl commented Feb 4, 2019

What time is it released?😄

@mohsinulhaq

This comment has been minimized.

Copy link

mohsinulhaq commented Feb 4, 2019

i don't think the requested changes were addressed :(

gaearon added some commits Feb 4, 2019

@@ -6,6 +6,33 @@
</summary>
</details>

## 16.8.0 (Maybe February 4, 2019 but we've moved it before so please don't rely on it.)

This comment has been minimized.

@dudenamedjune

dudenamedjune Feb 4, 2019

Could you delete this maybe, it will surely release if you do 🥑

@jeemyeong

This comment has been minimized.

Copy link

jeemyeong commented Feb 5, 2019

I am still waiting for what I was looking forward to.

@impulse

This comment has been minimized.

Copy link

impulse commented Feb 5, 2019

I am still waiting for what I was looking forward to.

Good things come for those who wait 👍

@mohsinulhaq

This comment has been minimized.

Copy link

mohsinulhaq commented Feb 5, 2019

*insert waiting pablo escobar meme here*

acdlite added some commits Feb 5, 2019


* Support Hooks in the shallow renderer. ([@trueadm](https://github.com/trueadm) in [#14567](https://github.com/facebook/react/pull/14567))
* Fix wrong state in `shouldComponentUpdate` in the presence of `getDerivedStateFromProps` for Shallow Renderer. ([@chenesan](https://github.com/chenesan) in [#14613](https://github.com/facebook/react/pull/14613))
* Add `ReactTestUtils.act()` for batching updates so that tests more closely match real behavior. ([@threepointone](https://github.com/threepointone) in [#14744])

This comment has been minimized.

@gaearon

gaearon Feb 5, 2019

Author Member

This link doesn’t work. Needs to be an actual link.

Also technically not test renderer but test utils. See past Changelogs.

Or I guess there should be two entries because there are two new APIs. One in test renderer section and one in test utils.

pull bot pushed a commit to SimenB/react that referenced this pull request Feb 6, 2019

Add 16.8.0 changelog and update some READMEs (facebook#14692)
* Add 16.8.0 changelog

* Mention ESLint plugin

* Remove experimental notices from the ESLint plugin README

* Update CHANGELOG.md

* Add more details for Hooks

* fix

* Set a date

* Update CHANGELOG.md

Co-Authored-By: gaearon <dan.abramov@gmail.com>

* Update CHANGELOG.md

* useReducer in changelog

* Add to changelog

* Update date

* Add facebook#14119 to changelog

* Add facebook#14744 to changelog

* Fix PR links

* act() method was added to test utils, too

* Updated release date to February 6th

pull bot pushed a commit to SimenB/react that referenced this pull request Feb 6, 2019

Add 16.8.0 changelog and update some READMEs (facebook#14692)
* Add 16.8.0 changelog

* Mention ESLint plugin

* Remove experimental notices from the ESLint plugin README

* Update CHANGELOG.md

* Add more details for Hooks

* fix

* Set a date

* Update CHANGELOG.md

Co-Authored-By: gaearon <dan.abramov@gmail.com>

* Update CHANGELOG.md

* useReducer in changelog

* Add to changelog

* Update date

* Add facebook#14119 to changelog

* Add facebook#14744 to changelog

* Fix PR links

* act() method was added to test utils, too

* Updated release date to February 6th

pull bot pushed a commit to chojar/react that referenced this pull request Feb 6, 2019

Add 16.8.0 changelog and update some READMEs (facebook#14692)
* Add 16.8.0 changelog

* Mention ESLint plugin

* Remove experimental notices from the ESLint plugin README

* Update CHANGELOG.md

* Add more details for Hooks

* fix

* Set a date

* Update CHANGELOG.md

Co-Authored-By: gaearon <dan.abramov@gmail.com>

* Update CHANGELOG.md

* useReducer in changelog

* Add to changelog

* Update date

* Add facebook#14119 to changelog

* Add facebook#14744 to changelog

* Fix PR links

* act() method was added to test utils, too

* Updated release date to February 6th
@bvaughn

This comment has been minimized.

Copy link
Contributor

bvaughn commented Feb 6, 2019

Not sure what's going on with this PR. The "Squash and merge" button does nothing (just times out) but the commit has already been merged– (I've verified the contents of master against this PR)– so I'm going to just close it.

@bvaughn bvaughn closed this Feb 6, 2019

@bvaughn bvaughn deleted the gaearon-patch-3 branch Feb 6, 2019

@RobinMalfait

This comment has been minimized.

Copy link

RobinMalfait commented Feb 6, 2019

@bvaughn is it because this is synced with some internal system?

@bvaughn

This comment has been minimized.

Copy link
Contributor

bvaughn commented Feb 6, 2019

No. We do development GitHub first. (We do sync from GitHub to our internal Mercurial repo, but not the other way around.)

Kiku-git added a commit to Kiku-git/react that referenced this pull request Feb 10, 2019

Add 16.8.0 changelog and update some READMEs (facebook#14692)
* Add 16.8.0 changelog

* Mention ESLint plugin

* Remove experimental notices from the ESLint plugin README

* Update CHANGELOG.md

* Add more details for Hooks

* fix

* Set a date

* Update CHANGELOG.md

Co-Authored-By: gaearon <dan.abramov@gmail.com>

* Update CHANGELOG.md

* useReducer in changelog

* Add to changelog

* Update date

* Add facebook#14119 to changelog

* Add facebook#14744 to changelog

* Fix PR links

* act() method was added to test utils, too

* Updated release date to February 6th
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment