-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TestUtils.act] warn when using TestUtils.act in node #14768
Merged
threepointone
merged 4 commits into
facebook:master
from
threepointone:testutils-act-node-error
Feb 6, 2019
Merged
[TestUtils.act] warn when using TestUtils.act in node #14768
threepointone
merged 4 commits into
facebook:master
from
threepointone:testutils-act-node-error
Feb 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
threepointone
commented
Feb 6, 2019
•
edited
Loading
edited
- lazily initializes the stub element we use when flushing effects
- adds a warning for when you try to run in in node (rather, non-document envs)
- fixes 16.8 regression: react-dom/test-utils no longer require()-able in pure node #14764
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 0975ea3...66f8e66 react-dom
Generated by 🚫 dangerJS |
acdlite
approved these changes
Feb 6, 2019
threepointone
changed the title
[TestUtils.act] throw when using TestUtils.act in node
[TestUtils.act] warn when using TestUtils.act in node
Feb 6, 2019
Out of curiosity what is the release cycle for patch releases? |
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Feb 8, 2019
* warn when using TestUtils.act in node * s/warns/throws * s/throw/warn * consistent ellipses
This was referenced Aug 12, 2019
This was referenced Aug 20, 2019
This was referenced Aug 27, 2019
This was referenced Aug 31, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* warn when using TestUtils.act in node * s/warns/throws * s/throw/warn * consistent ellipses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.