Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestUtils.act] warn when using TestUtils.act in node #14768

Merged

Conversation

@threepointone
Copy link
Contributor

commented Feb 6, 2019

  • lazily initializes the stub element we use when flushing effects
  • adds a warning for when you try to run in in node (rather, non-document envs)
  • fixes #14764
@sizebot

This comment has been minimized.

Copy link

commented Feb 6, 2019

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: 0975ea3...66f8e66

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.production.min.js 0.0% 0.0% 105.03 KB 105.03 KB 33.9 KB 33.9 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 107.96 KB 107.96 KB 34.77 KB 34.77 KB UMD_PROFILING
react-dom.profiling.min.js 0.0% 0.0% 108.28 KB 108.28 KB 34.17 KB 34.17 KB NODE_PROFILING
ReactDOM-profiling.js 0.0% 0.0% 320.87 KB 320.87 KB 58.92 KB 58.92 KB FB_WWW_PROFILING
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.05 KB 105.05 KB 33.91 KB 33.91 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 107.97 KB 107.97 KB 34.78 KB 34.78 KB UMD_PROFILING
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 108.29 KB 108.29 KB 34.17 KB 34.18 KB NODE_PROFILING
react-dom-test-utils.development.js +1.2% +1.2% 46.16 KB 46.7 KB 12.69 KB 12.84 KB UMD_DEV
react-dom-test-utils.production.min.js 🔺+0.2% 🔺+0.3% 10.11 KB 10.13 KB 3.74 KB 3.76 KB UMD_PROD
react-dom-test-utils.development.js +1.2% +1.2% 45.88 KB 46.42 KB 12.63 KB 12.78 KB NODE_DEV
react-dom-test-utils.production.min.js 🔺+0.2% 🔺+0.3% 9.89 KB 9.91 KB 3.68 KB 3.69 KB NODE_PROD
ReactTestUtils-dev.js +1.6% +1.5% 42.72 KB 43.39 KB 11.56 KB 11.73 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 11.01 KB 11.01 KB 3.81 KB 3.81 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.29 KB 60.29 KB 15.79 KB 15.79 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.75 KB 10.75 KB 3.71 KB 3.71 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 122.77 KB 122.77 KB 32.13 KB 32.13 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 707 B 706 B UMD_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 668 B 667 B NODE_PROD

Generated by 🚫 dangerJS

@acdlite
acdlite approved these changes Feb 6, 2019
@threepointone threepointone changed the title [TestUtils.act] throw when using TestUtils.act in node [TestUtils.act] warn when using TestUtils.act in node Feb 6, 2019
@threepointone threepointone merged commit 1107b96 into facebook:master Feb 6, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@joepuzzo

This comment has been minimized.

Copy link

commented Feb 6, 2019

Out of curiosity what is the release cycle for patch releases?

n8schloss added a commit to n8schloss/react that referenced this pull request Feb 8, 2019
* warn when using TestUtils.act in node

* s/warns/throws

* s/throw/warn

* consistent ellipses
iyegoroff added a commit to iyegoroff/react that referenced this pull request Mar 9, 2019
* warn when using TestUtils.act in node

* s/warns/throws

* s/throw/warn

* consistent ellipses
@threepointone threepointone deleted the threepointone:testutils-act-node-error branch Jul 9, 2019
This was referenced Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.